Re: Fix for several musicxml2ly bugs. (issue 5697059)

[ptrcklschmdt]

On 2012/02/29 22:33:45, Julien Rioux wrote:
> This patch is not associated with any issue in the bug tracker. It
will not get
> a proper review until it is added there, and the automatic testing
shows that it
> does not cause any unexpected problems. Should it be added to issue
1983, or is
> it sufficiently different that we should open a new issue for it?

Well it would certainly be easier for me if we opened a new issue for
this patch as it contains fixes for several bugs I reported lately.  For
some of them no issues were opened. Here are the bugs / reports at
stake:
-) http://code.google.com/p/lilypond/issues/detail?id=1983
-)
http://old.nabble.com/musicxml2ly%3A-chordnames-placement-bug-td33309393.html
-) http://lists.gnu.org/archive/html/bug-lilypond/2012-02/msg00519.html

I also added 2 lines to Usage as the new command line options -m and
--midi hadn't been added yet.

Beyond that I have a partial fix for
(http://code.google.com/p/lilypond/issues/detail?id=1969). Should I make
a new patch or can I add the code here?

> There are a lot of formatting changes to musicxml.py that are
unnecessary and
> make it difficult to see the meaningful changes in your patch. You
also
> introduce whitespace errors. So please revert the changes to
musicxml.py except
> for...

> http://codereview.appspot.com/5697059/diff/1/scripts/musicxml2ly.py
> File scripts/musicxml2ly.py (right):


http://codereview.appspot.com/5697059/diff/1/scripts/musicxml2ly.py#newcode25
> scripts/musicxml2ly.py:25: # Store command-line options in a global
variable, so
> we can access them everywhere
> ...this typo...
OK.  Will do.  But I'll leave out the former lines 477 and 478 as this
_is_ a meaningful change.

Thanks for your help!
patrick

BTW: I should mention that the bugs in this patch were fixed by René
Fauck.

http://codereview.appspot.com/5697059/diff/1/scripts/musicxml2ly.py#newcode534
> scripts/musicxml2ly.py:534: return None
> ...and this thinko.


http://codereview.appspot.com/5697059/diff/1/scripts/musicxml2ly.py#newcode2570
> scripts/musicxml2ly.py:2570: p.version = ('''%prog (LilyPond)
2.15.24\n\n'''
> Especially, don't change this.



http://codereview.appspot.com/5697059/