[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: LSR updates

From: Phil Holmes
Subject: Re: LSR updates
Date: Sun, 8 Apr 2012 16:39:50 +0100

----- Original Message ----- From: "Graham Percival" <address@hidden>
To: "Phil Holmes" <address@hidden>
Cc: "Devel" <address@hidden>
Sent: Sunday, April 08, 2012 1:25 PM
Subject: Re: LSR updates

On Sun, Apr 08, 2012 at 12:36:05PM +0100, Phil Holmes wrote:
OK.  I'm in the final throes of updating the LSR and have found 2
issues exemplified by a single file.  In snippets/new we used to
have a file called, with a doctitle of "Screech and
Boink" and an LSR tag of "headwords".

First problem.  If this is added to the LSR with that Title, the
filename produced in the tarball is, which is

I approve of changing the filename.

So it would seem the docs would need updating.  But if I
git grep screech-boink I get 8 itely files (all the translations),
10 po/pot files plus a lytex file. Do all these need updating?  Is
there a quick grep-py way of doing it if so?

I suggest:
- add the new filename
- change it in the English docs
- tell the translators to update their stuff
- add a Critical issue for this update
- when the translators are done, remove the old filename.

Second problem. uses an explicit list of directories
where it takes snippets from to add them to Doc/snippets.  It's

So it doesn't even find, since it's only in the
headwords directory.  Does anyone know why makelsr doesn't just
iterate over all the subdirectories in the tarball, rather that
restricting itself to a specific list?

I didn't know about glob.glob() when I first wrote ?
I can't think of any other reason.

This issue could be fixed 3 ways: add a further tag to the snippet
in the LSR; extend the list of tags; or use all the files in the
directory.  I'd prefer the latter, since the current system is
confusing - it took me about an hour to work out why screech and
boink wasn't in the snippet listing.

I don't like the first one.  I'm fine with having the list of tags
extended further or looking at all subdirectories of the lsr
directory.  I think I have a slight preference for just extending
the list of tags, since that's a less intruisive change and thus
has less chance of blowing up in our faces.  But since you prefer
looking at all subdirectories, that's fine with me.

- Graham

I'm running checks after completing the updates - finding a few issues and fixing them as I go. The final set of changes will have passed make, make doc and make test.

It'll be a ginormous patch - I can't imagine anyone reviewing it. My suggestion is that I push it directly to staging, given the number of times I'll have tested it?

Phil Holmes

reply via email to

[Prev in Thread] Current Thread [Next in Thread]