[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Additions in event-listener.ly (issue 152600043 by address@hidden)
|
From: |
v . villenave |
|
Subject: |
Additions in event-listener.ly (issue 152600043 by address@hidden) |
|
Date: |
Fri, 17 Oct 2014 06:40:23 +0000 |
Greetings Philippe and James,
this looks good overall, I just have one minor comment.
https://codereview.appspot.com/152600043/diff/1/ly/event-listener.ly
File ly/event-listener.ly (right):
https://codereview.appspot.com/152600043/diff/1/ly/event-listener.ly#newcode129
ly/event-listener.ly:129: (+ 60 (ly:pitch-semitones
AFAICS, .ly files use spaces, not tabs. Check the indentation.
https://codereview.appspot.com/152600043/diff/1/ly/event-listener.ly#newcode144
ly/event-listener.ly:144: "note"
Strictly speaking, this isn't a "note". "Drumnote" may be too long, how
about "stroke" or something else?
https://codereview.appspot.com/152600043/
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- Additions in event-listener.ly (issue 152600043 by address@hidden),
v . villenave <=