Re: Fix LilyPond default fonts definition (issue 258160043 by address@hidden)

[trueroad]

https://codereview.appspot.com/258160043/diff/1/lily/font-config.cc
File lily/font-config.cc (right):

https://codereview.appspot.com/258160043/diff/1/lily/font-config.cc#newcode43
lily/font-config.cc:43: /* Create an empty configureation */
On 2015/08/08 14:08:45, lemzwerg wrote:
> s/configureation/configuration/

Done.

https://codereview.appspot.com/258160043/diff/1/lily/font-config.cc#newcode70
lily/font-config.cc:70: error (_f ("failed adding fontconfig
configuration file: %s",
On 2015/08/08 14:08:45, lemzwerg wrote:
> I think it's better to have

>    failed to add fontconfig configuration file `foo'

> instead of

>    failed adding fontconfig configuration file: foo

Done.

https://codereview.appspot.com/258160043/diff/1/mf/99-lilypond-fonts.conf.in
File mf/99-lilypond-fonts.conf.in (right):

https://codereview.appspot.com/258160043/diff/1/mf/99-lilypond-fonts.conf.in#newcode1
mf/99-lilypond-fonts.conf.in:1: <?xml version="1.0" encoding="UTF-8"?>
On 2015/08/08 14:08:45, lemzwerg wrote:
> just curious: Why is this `99-lilypond-fonts.conf.in' and not
> `99-lilypond-fonts.conf'?  What can be configured in this file?

When LilyPond is building, makefiles copy from
mf/99-lilypond-fonts.conf.in (source file) to
fonts/99-lilypond-fonts.conf (installed file).
configure script can replace some strings in this file by recognized
environments but this function is not used at this version.

https://codereview.appspot.com/258160043/