|
From: | thomasmorley65 |
Subject: | Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by address@hidden) |
Date: | Wed, 26 Aug 2015 09:24:54 +0000 |
On 2015/08/26 08:55:14, dak wrote:
https://codereview.appspot.com/257580043/diff/1/scm/lily-library.scm File scm/lily-library.scm (right):
https://codereview.appspot.com/257580043/diff/1/scm/lily-library.scm#newcode793
scm/lily-library.scm:793: char-set:whitespace)) A mostly theoretic musing: in the predicates documented in NR, we have `char-whitespace?' listed in "R5RS secondary predicates".
I don't know how it's implemented, but if people compare results, char-whitespace? might be the expected point of reference and it's not
like this
is performance-critical.
Using that would mean one less function in our codebase for the same functionality.
I just thought I'd mention it: it's by no means a necessary change or
even a
showstopper.
Sorry, too busy with non LilyPond work right now. Maybe I can continue the upcoming weekend. For now setting PATCH-NEEDS_WORK https://codereview.appspot.com/257580043/
[Prev in Thread] | Current Thread | [Next in Thread] |