Re: add some rarely used mensural clefs (issue 330120043 address@hidden)

[Phil Holmes]

----- Original Message ----- 
From: <address@hidden>
To: <address@hidden>
Cc: <address@hidden>; <address@hidden>
Sent: Sunday, September 10, 2017 2:02 PM
Subject: Re: add some rarely used mensural clefs (issue 330120043 
address@hidden)


> I am updating the doc to include these new clefs (and add all ancient
> clefs to appendix A10 and I noticed some identical outputs for
> 'different' clef names.
>
>
> https://codereview.appspot.com/330120043/diff/1/scm/parser-clef.scm
> File scm/parser-clef.scm (right):
>
> https://codereview.appspot.com/330120043/diff/1/scm/parser-clef.scm#newcode96
> scm/parser-clef.scm:96: ("petrucci-g2" . ("clefs.petrucci.g" -2 0))
> Is this correct?
>
> I know nothing about ancient notation, but it seems that "petrucci-g2"
> is identical "petrucci-g" (below) apart from using 'g2' instead of 'g1'.
>
> On a similar note I can see that petrucci-f and f4 also are identical
> (and produce the same output).
>
> https://codereview.appspot.com/330120043/


I just put a long comment on the issue tracker about this, but got "spambot 
protection engaged" and it appeared to junk my comments.  So I'll try again.

James - there's more work to be done here, I'm afraid.  The mensural clef 
table that you've replaced with some examples - most of the examples aren't 
actually mensural clefs, they're Gregorian.  In this part of the NR you 
should _only_ have clefs with "mensural in their name".  Further down in the 
NR there is a section on Gregorian clefs and this should almost certainly be 
updated in the same way as you have done in the mensural clefs section. 
However, it's worth looking at the code that is used to create this section 
currently - you'll see that the example notes are different from the ones 
you've used in the appendix.  This is because mensural notes would not be 
used in Gregorian music, so the appendix needs updating to use the same note 
types as the existing table in the Gregorian clef section of the NR.

Hope this is useful and please shout if you want further information or 
help.

--
Phil Holmes