Re: issue 5319: Make skylines reflect grob rotation (issue 342060043 by address@hidden)

[James Lowe]

I am top posting....

Torsten,

Can you make a new patch based on current master as this one no longer applies 
so I cannot test it even without the *.cc file - I think it is because of a 
recent push to master for changes.tely this morning.

James

On Thu, 03 May 2018 05:51:11 -0700, address@hidden wrote:

> Reviewers: ,
> 
> Message:
> Please review...
> 
> Inadvertently, file
> ../lily/key-signature-interface.cc
> slipped into the patch (from issue 5312 currently in staging).
> 
> So ignore is (or shall I upload a new, cleansed patch for reviewing?)
> 
> Thanks,
> Torsten
> 
> Description:
> issue 5319: Make skylines reflect grob rotation
> 
> modified:   ../lily/include/stencil.hh
> Add parameter to skylines_from_stencil for rot (in analogy to pad)
> 
> modified:   ../lily/stencil-integral.cc
> 
> Stencil::skylines_from_stencil
> If new rotation parameter rot is specified, use a rotated copy of
> the original stencil to build the skyline transformation matrix.
> As the rotation is rarely used, the general (non-rotated) case will
> still use the original stencil as before.
> 
> Grob::vertical_sklyines_from_grob and
> Grob::horizontal_skylines_from_grob
> Read "rotation" property an pass it (SCM) to skylines_from_stencil.
> 
> modified:   ../lily/accidental.cc
> 
> Accidental_interface::horizontal_skylines
> Read "rotation" property and pass it (SCM) to skylines_from_stencil.
> 
> Announced in ../Documentation/changes.tely
> 
> Documentation example slightly adapted (20° to 15°) to new skyline
> behaviour (padding will now be respected). In all affected languages:
> modified:   ../Documentation/de/notation/changing-defaults.itely
> modified:   ../Documentation/es/notation/changing-defaults.itely
> modified:   ../Documentation/fr/notation/changing-defaults.itely
> modified:   ../Documentation/it/notation/changing-defaults.itely
> modified:   ../Documentation/ja/notation/changing-defaults.itely
> modified:   ../Documentation/notation/changing-defaults.itely
> 
> modified:   ../input/regression/skyline-color-rotation.ly
> (20° to 15°, cf. documentation)
> 
> new:   ../input/regression/skyline-grob-rotation.ly
> New regression test.
> 
> 
> 
> Please review this at https://codereview.appspot.com/342060043/
> 
> Affected files (+109, -25 lines):
>    M Documentation/changes.tely
>    M Documentation/de/notation/changing-defaults.itely
>    M Documentation/es/notation/changing-defaults.itely
>    M Documentation/fr/notation/changing-defaults.itely
>    M Documentation/it/notation/changing-defaults.itely
>    M Documentation/ja/notation/changing-defaults.itely
>    M Documentation/notation/changing-defaults.itely
>    A input/regression/skyline-grob-rotation.ly
>    M input/regression/stencil-color-rotation.ly
>    M lily/accidental.cc
>    M lily/include/stencil.hh
>    M lily/key-signature-interface.cc
>    M lily/stencil-integral.cc
> 
> 
> _______________________________________________
> lilypond-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/lilypond-devel