[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: issue 5319: Make skylines reflect grob rotation (issue 342060043 by
|
From: |
torsten . haemmerle |
|
Subject: |
Re: issue 5319: Make skylines reflect grob rotation (issue 342060043 by address@hidden) |
|
Date: |
Thu, 03 May 2018 10:58:00 -0700 |
On 2018/05/03 17:42:22, lemzwerg wrote:
LGTM
https://codereview.appspot.com/342060043/diff/1/lily/key-signature-interface.cc
File lily/key-signature-interface.cc (right):
https://codereview.appspot.com/342060043/diff/1/lily/key-signature-interface.cc#newcode114
lily/key-signature-interface.cc:114: padding += (intersection
(ht_right,
last_ht_left).length ()
The outermost parentheses on the right side are redundant.
Hi Werner,
the key-signature-interface.cc slipped in only accidentally and does not
belong to this issue. It has disappeared from 2nd patch set. There was
also a mismatch in changes.tely and James aked me to make a new patch
against current master.
Apart from that, yes, the parentheses are redundant, but they were also
there in the original coding and so I kept them...
All the best,
Torsten
https://codereview.appspot.com/342060043/