lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

sort input files (issue 347770043 by address@hidden)


From: dak
Subject: sort input files (issue 347770043 by address@hidden)
Date: Fri, 18 May 2018 06:32:26 -0700


https://codereview.appspot.com/347770043/diff/1/stepmake/stepmake/c++-vars.make
File stepmake/stepmake/c++-vars.make (right):

https://codereview.appspot.com/347770043/diff/1/stepmake/stepmake/c++-vars.make#newcode14
stepmake/stepmake/c++-vars.make:14: CC_FILES := $(sort $(call
src-wildcard,*.cc))
src-wildcard actually uses the wildcard function of Make.  The
documentation of it does not mention sorting in any manner.  However,
since it is modelled after shell globs, it would seem weird for it not
to sort.  So the question is whether this should rather be addressed in
Make or whether this is a symptom of a different problem (like
LC_COLLATE having different settings on different systems, something
likely also affecting the outcome of the "sort" function).  Short of
that, wouldn't it make more sense to redefine src-wildcard to always
sort?

It's defined as
stepmake/stepmake/generic-vars.make:src-wildcard = $(subst
$(src-dir)/,,$(wildcard $(src-dir)/$(1)))

https://codereview.appspot.com/347770043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]