[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: sort input files (issue 347770043 by address@hidden)
From: |
nine . fierce . ballads |
Subject: |
Re: sort input files (issue 347770043 by address@hidden) |
Date: |
Sat, 26 May 2018 06:04:12 -0700 |
On 2018/05/23 12:22:09, bmwiedemann wrote:
sorting .o files instead of .cc
This is not quite what I meant. If it works for you, fine, but I think
it is more likely to break eventually than if you found the commands
that are being invoked and sorted their arguments. For example,
$(CXX) -o $@ $(sort $(O_FILES)) blah blah blah
This puts the sort where it really matters and leaves no room for
modifying O_FILES after the sort. It would still be a good idea to
include a short comment on the reason for the sort, because It isn't
obvious.
https://codereview.appspot.com/347770043/