Re: make doc bombs out in MusicXML

[James Lowe]

Hello,

On Sat, 16 Jun 2018 14:21:28 +0200, David Kastrup <address@hidden> wrote:

> 
> I get the following:
> 
> lilypond-book.py: error: `musicxml2ly  --out=- - ' failed (0)
> lilypond-book.py: error: The error log is as follows:
> musicxml2ly: Reading MusicXML from Standard input ...
> musicxml2ly: Converting to LilyPond expressions...
> Traceback (most recent call last):
>   File "/tmp/build-lilypond-autobuild/scripts/out/musicxml2ly", line 3297, in 
> <module>
>     main()
>   File "/tmp/build-lilypond-autobuild/scripts/out/musicxml2ly", line 3291, in 
> main
>     voices = convert(filename, options)
>   File "/tmp/build-lilypond-autobuild/scripts/out/musicxml2ly", line 3168, in 
> convert
>     (voices, staff_info) = get_all_voices(parts)
>   File "/tmp/build-lilypond-autobuild/scripts/out/musicxml2ly", line 2776, in 
> get_all_voices
>     voice = musicxml_voice_to_lily_voice(v)
>   File "/tmp/build-lilypond-autobuild/scripts/out/musicxml2ly", line 2332, in 
> musicxml_voice_to_lily_voice
>     for direction in musicxml_direction_to_lily(n):
>   File "/tmp/build-lilypond-autobuild/scripts/out/musicxml2ly", line 1580, in 
> musicxml_direction_to_lily
>     event = musicxml_metronome_to_ly(next_entry, entry)
>   File "/tmp/build-lilypond-autobuild/scripts/out/musicxml2ly", line 1490, in 
> musicxml_metronome_to_ly
>     ev.set_text(text_event.get_text().strip())
> AttributeError: TempoMark instance has no attribute 'set_text'
> /tmp/build-lilypond-autobuild/scripts/build/out/texi2omf --format pdf 
> --location 
> /usr/local/share/doc/lilypond/html/input/regression/musicxml/collated-files.pdf
>   --version 2.21.0 out-www/collated-files.texi > 
> out-www/collated-files.pdf.omf
> Traceback (most recent call last):
>   File "/tmp/build-lilypond-autobuild/scripts/build/out/texi2omf", line 73, 
> in <module>
>     texi = open (infile).read ()
> IOError: [Errno 2] No such file or directory: 'out-www/collated-files.texi'
> /tmp/lilypond-autobuild/./make/ly-rules.make:43: recipe for target 
> 'out-www/collated-files.pdf.omf' failed
> make[4]: *** [out-www/collated-files.pdf.omf] Error 1
> 
> This is standard lilypond-patchy-staging on my side so I am somewhat
> puzzled why with this error in place (which appears to point to an
> inconsistency in musicxml) the current state of master could have
> included this patch.  Maybe my version of Python is less lenient about
> undefined members or something?
> 
> At any rate, I lean towards reverting the work of Alexander Myltsev
> until this has been cleared up.
> 
> Opinions?
> 
> -- 

Well before I applied those patches on behalf of Alexander's patches I did a 
full patch test with the patches applied and had no problems.

However ... I know that there are some 'prgramming errors' reported that do not 
break patch testing. I wonder if this is something like that.

My work machine will be running merge every 4 hours, but I'll kick one off from 
home now (~ 13:45 BST)

James