[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: fingering-engraver.cc: don't set Fingering.pitch (issue 347930043 by
From: |
dak |
Subject: |
Re: fingering-engraver.cc: don't set Fingering.pitch (issue 347930043 by address@hidden) |
Date: |
Fri, 03 Aug 2018 01:51:12 -0700 |
On 2018/08/03 08:25:32, hanwenn wrote:
LGTM
Thanks. For the record, I am currently renaming get_property and
set_property for grobs since I want to change their internals in a
manner not compatible with the existing get_property macro (which does
not get to know what kind of class it is being used on). So I did a
rename job for all known grob properties (quite a nuisance because
probably 15% of stuff like "direction" or "text" ended up not being a
grob property after all) and cleaned up afterwards. And a few things
just didn't clean up.
This is one.
https://codereview.appspot.com/347930043/