Re: ly: updates to hel-arabic.ly (issue 349810043 by address@hidden)

[pkxgnugitcl]

Thanks for the review Malte


https://codereview.appspot.com/349810043/diff/1/ly/hel-arabic.ly
File ly/hel-arabic.ly (left):

https://codereview.appspot.com/349810043/diff/1/ly/hel-arabic.ly#oldcode73
ly/hel-arabic.ly:73: %% Sajakar: c' d' edb' f' g' ab' b' c'' c'' bb' a'
g' f' edb' d' c'
On 2018/12/12 08:55:01, Malte Meyn wrote:
> Is this “never used” in the same way as locrian mode, i. e. only in
theory?

From Hassan:

rast   :  c d  edb  f  g  a bdb c
sajkar :  c dd edb  f  g  a bdb c

rast = #`(
  (0 . ,NATURAL)
  (1 . ,NATURAL)
  (2 . ,SEMI-FLAT)
  (3 . ,NATURAL)
  (4 . ,NATURAL)
  (5 . ,NATURAL)
  (6 . ,SEMI-FLAT)
)

This is rast with the altered note in dd (dis). That's why musicians
arabic use rast by altering the note d in dd (dis)

%% Sajakar: c dd edb  f  g  a bdb   (good)
sajkar = #`(
  (0 . ,NATURAL)
  (1 . ,SHARP)
  (2 . ,SEMI-FLAT)
  (3 . ,NATURAL)
  (4 . ,NATURAL)
  (5 . ,NATURAL)
  (6 . ,SEMI-FLAT)
)

it replaces ( an error here  in hel-arabic.ly )

(bad )
sajkar = #`(
  (0 . ,NATURAL)
  (1 . ,NATURAL)
  (2 . ,SEMI-FLAT)
  (3 . ,NATURAL)
  (4 . ,NATURAL)
  (5 . ,FLAT)
  (6 . ,NATURAL)
)

https://codereview.appspot.com/349810043/diff/1/ly/hel-arabic.ly#oldcode248
ly/hel-arabic.ly:248: %% Irak: bdb c d edb f g a bdb bb a g f edb d c
bdb
On 2018/12/12 08:55:01, Malte Meyn wrote:
> Are these identical to “rast” in the same way ionian is to major? Then
I
> wouldn’t delete them. Maybe simply #(define iraq rast) or iraq = \rast

From Hassan:

No they arent' identical to rast in the same way ionian to major .

in fact

rast :  c d edb f g a bdb c ( it also includes the note bb (bes) )
irak :  bdb c d edb f g a bdb
rahatalarouah : bdb c d edb fd g a bdb
alboustankar  : bdb c d edb f gb a bdb

As you see iraq, rahatalarouah and alboustankar contain edb and bdb
notes.
But the rast key includes edb and bdb. So Arab musicians use the key of
rast to write irak, rahatalarouah and alboustankar

https://codereview.appspot.com/349810043/diff/1/ly/hel-arabic.ly#oldcode334
ly/hel-arabic.ly:334: major = #`(
On 2018/12/12 08:55:01, Malte Meyn wrote:
> Does hel-arabic.ly *replace* scale-definitions-init.ly? If not, these
> definitions are redundant.

From Hassan:

hel-arabic.ly don't need scale-definitions-init.ly.
in other words it replaces scale-definitions-init.ly (minor, major,...
are defined
in hel-arabic.ly).

There is no interaction between hel-arabic.ly and
scale-definitions-init.ly
In addition, it uses bb (b flat) instead of bes and dd (d sharp) instead
of dis for example.

We write music independently.
There is of course edb (e semi-flat), fdd (f semi-sharp ).....
Major and minor makams exist in Arabic music. They have different names
:  ajam (for major)
and nahawand (for minor)

In conclusion

I think it's better to delete them.

Also

Reminder:
---------
hel-arabic.ly uses define-note-names.scm  and  lily-library.scm
define-note-names.scm and lily-library.scm are not modified

https://codereview.appspot.com/349810043/diff/1/ly/hel-arabic.ly
File ly/hel-arabic.ly (right):

https://codereview.appspot.com/349810043/diff/1/ly/hel-arabic.ly#newcode158
ly/hel-arabic.ly:158: (4 . FLAT)
On 2018/12/12 08:55:01, Malte Meyn wrote:
> Should be ,FLAT (with comma). Or ,SHARP == 1/2?

Yes this should have a comma.

https://codereview.appspot.com/349810043/