Re: 2.19.80 restNumberThreshold

[David Kastrup]

"Phil Holmes" <address@hidden> writes:

> ----- Original Message ----- 
> From: "David Kastrup" <address@hidden>
> To: "Paul Scott" <address@hidden>
> Cc: "LilyPond User List" <address@hidden>
> Sent: Saturday, November 04, 2017 2:52 PM
> Subject: Re: 2.19.80 restNumberThreshold
>
>
>> Paul Scott <address@hidden> writes:
>>
>>> For some time restNumberThreshold has not worked for me.
>>>
>>> \version "2.19.80"
>>>
>>> \relative{
>>>   c''1
>>>   \set Score.restNumberThreshold = #0 R
>>>   \set Score.restNumberThreshold = #1 R
>>> }
>>>
>>> This does not put a "1" over the 2nd bar.  What have I missed?
>>
>> Huh.  Take a look at
>>
>> \version "2.19.80"
>>
>> \relative{
>>  c''1
>>  \set Score.restNumberThreshold = #0 R1*3 R1*3
>>  \set Score.restNumberThreshold = #1 R1*3 R1*3
>>  \set Score.restNumberThreshold = #2 R1*3 R1*3
>>  \set Score.restNumberThreshold = #3 R1*3 R1*3
>> }
>>
>> This looks more than weird.
>
> The change from 6 numbers being shown to 5 occurred sometime between
> 2.19.23 and 1.19.28.

address@hidden:/usr/local/tmp/lilypond$ git log 
release/2.19.23-1..release/2.19.28-1 -i --grep mmr
commit 2e22eccfe90cd2a5daf444984efce9c9d9a9c414
Author: Dan Eble <address@hidden>
Date:   Sun Sep 6 14:37:42 2015 -0400

    Issue 4594 (4/4): mmrest engraver: rearrange for readability

commit dbf24b4acd242a4c4282df1d80d762322364a680
Author: Dan Eble <address@hidden>
Date:   Sun Sep 6 13:38:22 2015 -0400

    Issue 4594 (3/4) mmrest engraver: simplify logic

commit d95c9d14c0f6e5a10491235943d5b42e020d1920
Author: Dan Eble <address@hidden>
Date:   Sun Sep 6 13:35:50 2015 -0400

    Issue 4594 (2/4) mmrest engraver: move most processing into process_music()
    
    This opens the way to using more local state rather than object state.

commit e733b3f0e710be67621d52b70cfd0d3df113ed56
Author: Dan Eble <address@hidden>
Date:   Fri Sep 4 16:01:39 2015 -0400

    Issue 4594 (1/4) mmrest engraver: comments, naming, style


That looks like a reasonable candidate.  In particular (2/4) and (3/4).

-- 
David Kastrup