linphone-developers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Linphone-developers] Linphone IOS issues


From: Дмитрий Погоняев
Subject: [Linphone-developers] Linphone IOS issues
Date: Thu, 25 May 2017 12:57:10 +0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1

Hello.

I found some problems in Linphone for iOS, which I want to report.

The first problem is related to the rotation of the screen:
1) Launch Linphone from the AppStore
2) Open the contacts. -> Details of the contact
3) Rotate the screen.
4) We observe the displacement of the table of numbers along the Y axis.
(It is best seen by the example of contact with a large number of telephones)

Estimated error location:
ContactDetailsView.m
- (void)observeValueForKeyPath:(NSString *)keyPath
                      ofObject:(id)object
                        change:(NSDictionary *)change
                       context:(void *)context {
//------------------------------------------------------
    CGRect frame = _tableController.tableView.frame;
    frame.size = _tableController.tableView.contentSize;
    _tableController.tableView.frame = frame;
//------------------------------------------------------
    [self recomputeContentViewSize];
}

Comment:
This method is called multiple times, different values of Y at each iteration.
To test the recommendation, create a contact with a large number of phones.
In this case, you can observe one more bug:
1) Open the detailed contact information screen. (9+ numbers)
2) Press the "Back" button.
3) Again open this contact.
4) Try to scroll contents.
As a result, only that part of the contact that was in the region of the primary mapping will be reflected.
The place of other numbers will be empty.
Probably the problem is with manual resizing of rectangles.


The second problem is the cancellation of creating a new contact.
1) Launch Linphone from the AppStore. (You may need to have an account)
2) Open the contacts and press the button to create a new contact.
3) Enter the data in the SIP field.
4) Press the "cancel" button.
5) Open the phone contacts list. We see the nameless contact with the empty SIP address field.

Estimated error location:
Contact.m
- (BOOL)setSipAddress:(NSString *)sip atIndex:(NSInteger)index {
  BOOL ret = FALSE;
  NSString *normSip = NULL;
  if (_person) {
//-------------------------------------------------------------------
     normSip = [self setOrCreateSipContactEntry:index withValue:sip];
//-------------------------------------------------------------------
     NSDictionary *lDict = @{
(NSString *)kABPersonInstantMessageUsernameKey : normSip ? normSip : sip, (NSString *)kABPersonInstantMessageServiceKey : LinphoneManager.instance.contactSipField
     };
...
}

Comment:
Used for validation, but leads to incorrect behavior - creating a contact instead of canceling.

--
С уважением, Дмитрий Погоняев.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]