lmi-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] master 77d1a39 4/5: Change wxWidgets window "name" p


From: Greg Chicares
Subject: [lmi-commits] [lmi] master 77d1a39 4/5: Change wxWidgets window "name" parameter to use wxString type (VZ)
Date: Tue, 21 Feb 2017 11:44:27 -0500 (EST)

branch: master
commit 77d1a39b140ccd5823b5a1100173cca6930fa913
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Change wxWidgets window "name" parameter to use wxString type (VZ)
    
    It doesn't make sense to use std::string for a string which, by
    definition, is only used in the code using wxWidgets as it it passed
    to wxWindow::Create() as a parameter.
    
    Changing its type removes the need for an explicit type conversion
    from wxString to std::string.
---
 rounding_view_editor.cpp | 4 ++--
 rounding_view_editor.hpp | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/rounding_view_editor.cpp b/rounding_view_editor.cpp
index d03f1a7..5d3b437 100644
--- a/rounding_view_editor.cpp
+++ b/rounding_view_editor.cpp
@@ -179,7 +179,7 @@ void RoundingButtons::Create
     ,wxPoint const&     pos
     ,wxSize const&      size
     ,long               style
-    ,std::string const& name
+    ,wxString const&    name
     )
 {
     wxPanel::Create(parent, id, pos, size, style, name);
@@ -379,7 +379,7 @@ wxObject* RoundingButtonsXmlHandler::DoCreateResource()
         ,GetPosition()
         ,GetSize()
         ,GetStyle()
-        ,std::string(GetName())
+        ,GetName()
         );
 
     SetupWindow(control);
diff --git a/rounding_view_editor.hpp b/rounding_view_editor.hpp
index 05a5806..901c7e5 100644
--- a/rounding_view_editor.hpp
+++ b/rounding_view_editor.hpp
@@ -56,7 +56,7 @@ class RoundingButtons
         ,wxPoint const&     pos   = wxDefaultPosition
         ,wxSize const&      size  = wxDefaultSize
         ,long               style = 0
-        ,std::string const& name  = wxPanelNameStr
+        ,wxString const&    name  = wxPanelNameStr
         );
 
     bool IsModified() const;



reply via email to

[Prev in Thread] Current Thread [Next in Thread]