[lmi-commits] [lmi] master 401a6cc 1/3: Suppress warnings when building libxml2 et cetera

[Greg Chicares]

branch: master
commit 401a6ccc41481ec3dc303c1d5bd36b472c90f128
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Suppress warnings when building libxml2 et cetera
    
    Building 'install_libxml2_libxslt.make' gives
      3736 lines of output before this change
      2061 lines of output after  this change
      1675 = 3736 - 2061
    The warnings are assumed to be benign because lmi has built these
    libraries the same way for years with no apparent problem. Suppressing
    them is useful because cluttering build logs makes it harder to notice
    diagnostics that really are significant. For example, in the log of a
    recent 'install_msw.sh' run
      $wc log-20180411T0857Z
         6366   77499 1220816 log-20180411T0857Z
    1675/6366 = 26% of the total lines are ignorable diagnostics from this
    particular makefile alone.
    
    Prefixed '-g -O2' to $CFLAGS overrides because that was the previous
    behavior when $CFLAGS was not overridden:
      https://www.gnu.org/software/autoconf/manual/autoconf.html
    | If output variable CFLAGS was not already set, set it to -g -O2 for
    | the GNU C compiler
    
    Eight '-Wsuggest-attribute=format' warnings remain despite the attempt
    to inhibit them with '-Wno-suggest-attribute=format'.
---
 install_libxml2_libxslt.make | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/install_libxml2_libxslt.make b/install_libxml2_libxslt.make
index 858ae6c..ae65be1 100644
--- a/install_libxml2_libxslt.make
+++ b/install_libxml2_libxslt.make
@@ -68,12 +68,19 @@ ifeq (CYGWIN,$(findstring CYGWIN,$(uname)))
   host_type     := i686-w64-mingw32
 endif
 
+xz_cflags := \
+  -Wno-format \
+  -Wno-format-extra-args \
+  -Wno-implicit-fallthrough \
+  -Wno-maybe-uninitialized \
+
 $(xz_version)_options := \
   --prefix=$(prefix) \
   --exec-prefix=$(exec_prefix) \
   --build=$(build_type) \
   --host=$(host_type) \
   --disable-dependency-tracking \
+  CFLAGS="-g -O2 $(xz_cflags)" \
 
 # For 'host' and 'build' configure options, see:
 #   http://cygwin.com/ml/cygwin/2002-01/msg00837.html
@@ -85,6 +92,28 @@ $(xz_version)_options := \
 # which elicit fatal errors such as this:
 #   .deps/DOCBparser.Plo:1: *** multiple target patterns.  Stop.
 
+xmlsoft_common_cflags := \
+  -Wno-cpp \
+  -Wno-discarded-qualifiers \
+  -Wno-format \
+  -Wno-format-extra-args \
+  -Wno-implicit-fallthrough \
+  -Wno-implicit-function-declaration \
+  -Wno-maybe-uninitialized \
+  -Wno-misleading-indentation \
+  -Wno-missing-format-attribute \
+  -Wno-missing-prototypes \
+  -Wno-nested-externs \
+  -Wno-pedantic \
+  -Wno-pointer-sign \
+  -Wno-sign-compare \
+  -Wno-strict-prototypes \
+  -Wno-suggest-attribute=format \
+  -Wno-unused-but-set-variable \
+  -Wno-unused-function \
+  -Wno-unused-parameter \
+  -Wno-unused-variable \
+
 xmlsoft_common_options := \
   --prefix=$(prefix) \
   --exec-prefix=$(exec_prefix) \
@@ -96,6 +125,8 @@ xmlsoft_common_options := \
   --with-debug \
   --without-python \
   LDFLAGS='-lws2_32' \
+  CPPFLAGS="-w" \
+  CFLAGS="-g -O2 $(xmlsoft_common_cflags)" \
 
 $(libxml2_version)_options := \
   $(xmlsoft_common_options) \