[lmi-commits] [lmi] master fdb7cfa 1/4: Enable '-Wconversion' for almost all object files

[Greg Chicares]

branch: master
commit fdb7cfa02f279d1489d1d0a1eea4cb7b2df4abb9
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Enable '-Wconversion' for almost all object files
    
    For now, this warning is disabled for ten object files out of 302.
---
 workhorse.make | 24 +++++++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)

diff --git a/workhorse.make b/workhorse.make
index b0f2ed5..4b54872 100644
--- a/workhorse.make
+++ b/workhorse.make
@@ -410,10 +410,8 @@ else ifneq (,$(filter $(gcc_version), 6.3.0))
   cxx_standard += -frounding-math
 else ifneq (,$(filter $(gcc_version), 7.2.0 7.3.0))
   # Rationale:
-  # -Wno-conversion             regrettable, but needed for wx
-  # -Wno-parentheses            beyond pedantic
+  # -Wno-parentheses [its diagnostics are beyond pedantic]
   gcc_version_specific_warnings := \
-    -Wno-conversion \
     -Wno-parentheses \
 
   cxx_standard := -std=c++17
@@ -474,6 +472,26 @@ gcc_cxx_warnings := \
 gcc_common_extra_warnings := \
   -Wcast-qual \
 
+# SOMEDAY !! Address some of these '-Wconversion' issues.
+
+wno_conv_objects := \
+  CgiUtils.o \
+  currency_test.o \
+  facets.o \
+  rate_table.o \
+  round_glibc.o \
+  tn_range_test.o \
+
+$(wno_conv_objects): gcc_common_extra_warnings += -Wno-conversion
+
+wno_float_conv_objects := \
+  financial_test.o \
+  gpt_server.o \
+  ihs_basicval.o \
+  mec_server.o \
+
+$(wno_float_conv_objects): gcc_common_extra_warnings += -Wno-float-conversion
+
 ifeq (safestdlib,$(findstring safestdlib,$(build_type)))
   ifeq (3.4.5,$(gcc_version))
     expression_template_0_test.o: gcc_common_extra_warnings += 
-Wno-unused-parameter