[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] master 8a68504 4/9: Call Reconcile() when reading al

From: Greg Chicares
Subject: [lmi-commits] [lmi] master 8a68504 4/9: Call Reconcile() when reading all external input files
Date: Thu, 12 Jul 2018 13:12:58 -0400 (EDT)

branch: master
commit 8a68504efefee1959d74d5bd76402d06eeec43c2
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Call Reconcile() when reading all external input files
    Previously, this was done only for '.cns' input; now, it's done for
    '.ill' input as well. (Others like '.gpt' never come from external
    sources.) This change may seem pointless per se, because loading an
    '.ill' file immediately opens the tabbed dialog, thereby triggering
    Reconcile() (and external files are not customarily used with CLI
    builds that have no dialog to open). However, it isn't a bad idea to
    handle both types of (external) files in the same way now, and soon
    it will become a very good idea because an additional validation step
    is about to be added.
 single_cell_document.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/single_cell_document.cpp b/single_cell_document.cpp
index b34d426..5944617 100644
--- a/single_cell_document.cpp
+++ b/single_cell_document.cpp
@@ -124,6 +124,10 @@ void single_cell_document::parse(xml_lmi::dom_parser 
const& parser)
     //  returning "*begin()" from front() actually results in a
     //  dangling reference'.
     *elements.begin() >> input_data_;
+    if(data_source_is_external(parser.document()))
+        {
+        input_data_.Reconcile();
+        }
 /// Ascertain whether input file comes from a system other than lmi.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]