[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 6465704 04/15: Restore the use of wxDCClipper
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 6465704 04/15: Restore the use of wxDCClipper in PDF table generation code |
Date: |
Fri, 27 Jul 2018 17:23:15 -0400 (EDT) |
branch: master
commit 6465704ed66d2dcd14a44a209c8f6ab0c83643a8
Author: Vadim Zeitlin <address@hidden>
Commit: Gregory W. Chicares <address@hidden>
Restore the use of wxDCClipper in PDF table generation code
The bug which resulted in the use of wxDCClipper leading to upside-down
text on the following pages was really fixed by adding the missing calls
to wxPdfDC::EndPage() in the previous commit and there is no reason not
to use it any longer.
This reverts (the really significant part of) the commit
f7e2663350f61c25a6c4f40a43c75859c35ed506
---
wx_table_generator.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/wx_table_generator.cpp b/wx_table_generator.cpp
index 9d745e8..5b7fa14 100644
--- a/wx_table_generator.cpp
+++ b/wx_table_generator.cpp
@@ -479,14 +479,14 @@ void wx_table_generator::do_output_single_row
// Make sure that any failure in this chain of assumptions
// doesn't result in (undefined) negative clipping.
LMI_ASSERT(0 <= ci.col_width() - column_margin());
- dc_.SetClippingRegion
- (wxRect
+ wxDCClipper clip
+ (dc_
+ ,wxRect
{wxPoint{pos_x, y_top}
,wxSize{ci.col_width() - column_margin(), row_height_}
}
);
dc_.DrawText(s, x_text, y_text);
- dc_.DestroyClippingRegion();
}
else
{
- [lmi-commits] [lmi] master updated (caaecd8 -> 12d84c9), Greg Chicares, 2018/07/27
- [lmi-commits] [lmi] master 37e9b0b 01/15: Update to wxWidgets v3.1.1-319-g9daf5bec98 snapshot, Greg Chicares, 2018/07/27
- [lmi-commits] [lmi] master 6465704 04/15: Restore the use of wxDCClipper in PDF table generation code,
Greg Chicares <=
- [lmi-commits] [lmi] master a8d5e26 08/15: Look for image files referenced in templates under data directory, Greg Chicares, 2018/07/27
- [lmi-commits] [lmi] master 005b3eb 06/15: Replace pdf_writer_wx::get_page_height() with get_total_height(), Greg Chicares, 2018/07/27
- [lmi-commits] [lmi] master 28e3c42 11/15: Remove workarounds for wx 3.1.1 warnings not relevant any more, Greg Chicares, 2018/07/27
- [lmi-commits] [lmi] master b6b6827 03/15: Do call EndPage() in PDF generation code, Greg Chicares, 2018/07/27
- [lmi-commits] [lmi] master a86d90a 02/15: Use more recent wxPdfDocument fixing the text origin bug, Greg Chicares, 2018/07/27
- [lmi-commits] [lmi] master 554eb23 13/15: Forbid page breaks inside paragraphs in the illustrations, Greg Chicares, 2018/07/27
- [lmi-commits] [lmi] master 271db22 14/15: Fix over eager assert in pdf_writer_wx::output_html(), Greg Chicares, 2018/07/27
- [lmi-commits] [lmi] master 12d84c9 15/15: Fix regression in font sizes used for the group quotes PDF, Greg Chicares, 2018/07/27
- [lmi-commits] [lmi] master 2bd38fa 12/15: Use standard <img> tag instead of <scaled_image> in templates, Greg Chicares, 2018/07/27
- [lmi-commits] [lmi] master 4cfcfe4 07/15: Refactor: remove render_page_template() helper function, Greg Chicares, 2018/07/27