[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 039924c 6/8: Refactor to prepare for a larger
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 039924c 6/8: Refactor to prepare for a larger refactoring |
Date: |
Wed, 12 Sep 2018 12:08:06 -0400 (EDT) |
branch: master
commit 039924cf0f836b246cbe3014b10ffc33cc14a55c
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>
Refactor to prepare for a larger refactoring
This commit has made the 26-line blocks beginning at lines 1468 and 1635
identical. (The preceding commit tested the safety of this commit.)
---
ledger_pdf_generator_wx.cpp | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/ledger_pdf_generator_wx.cpp b/ledger_pdf_generator_wx.cpp
index 6d262e2..743b7d2 100644
--- a/ledger_pdf_generator_wx.cpp
+++ b/ledger_pdf_generator_wx.cpp
@@ -1477,11 +1477,7 @@ class numeric_summary_table_cell
if(oe_shown == columns[j].visibility)
{
std::string output_value;
- if(is_last_row && column_policy_year == j)
- {
- output_value = summary_age_string;
- }
- else if(columns[j].variable_name.empty())
+ if(columns[j].variable_name.empty())
{
; // Separator column: use empty string.
}
@@ -1499,10 +1495,6 @@ class numeric_summary_table_cell
if(is_last_row)
{
- // If this assertion always succeeds, then the code
- // that establishes this invariant above, and the
- // assertion, can be removed.
- LMI_ASSERT(summary_age_string ==
visible_values.at(column_policy_year));
visible_values.at(column_policy_year) =
summary_age_string;
}
- [lmi-commits] [lmi] master updated (d8aa128 -> 7bf948b), Greg Chicares, 2018/09/12
- [lmi-commits] [lmi] master 039924c 6/8: Refactor to prepare for a larger refactoring,
Greg Chicares <=
- [lmi-commits] [lmi] master ff118b3 5/8: Assert that a refactoring will be safe, Greg Chicares, 2018/09/12
- [lmi-commits] [lmi] master 7bf948b 8/8: Refactor for clarity, Greg Chicares, 2018/09/12
- [lmi-commits] [lmi] master 0d7d4d5 4/8: Simplify some special-case logic to make it easier to relocate, Greg Chicares, 2018/09/12
- [lmi-commits] [lmi] master 99930af 1/8: Declare a variable only in the scope where it's used, Greg Chicares, 2018/09/12
- [lmi-commits] [lmi] master 039c1fd 2/8: Declare a variable only in the scope where it's used, Greg Chicares, 2018/09/12
- [lmi-commits] [lmi] master a049a0d 3/8: Forestall latent off-by-one errors, Greg Chicares, 2018/09/12
- [lmi-commits] [lmi] master 1445c8d 7/8: Merge two identical blocks into a single function, Greg Chicares, 2018/09/12