[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re[2]: [lmi] Makefile.am backslashes and check_concinnity
From: |
Vadim Zeitlin |
Subject: |
Re[2]: [lmi] Makefile.am backslashes and check_concinnity |
Date: |
Tue, 2 Sep 2008 12:49:31 +0200 |
On Mon, 01 Sep 2008 18:39:31 +0000 Greg Chicares <address@hidden> wrote:
GC> > in the future (or, at least, make it less likely that it happens) so
GC> > I'd also like to propose this patch:
GC> >
GC> > --- GNUmakefile 2008-07-19 14:50:18 +0000
GC> > +++ GNUmakefile 2008-09-01 17:14:07 +0000
GC> > @@ -342,6 +342,8 @@
GC> > done;
GC> > @$(ECHO) " Miscellaneous problems:"
GC> > @-$(TEST_CODING_RULES) *
GC> > + @perl -Mstrict -we 'undef $$/;exit(<>=~/\\\n[^ \t]/)' Makefile.am
\
GC> > + || $(ECHO) "Makefile.am contains incorrect continuation
lines."
GC>
GC> I'd much rather avoid making that makefile depend on perl.
What about the following sed version:
@$(ECHO) "Line numbers with incorrect continuation in Makefile.am:"
sed -n '/\\$$/{ N; /\\\n[^ \t]/=; D; }' Makefile.am
? It took me some time to realize that I had to use "D" to avoid skipping
every second line but the version above seems to work fine. It doesn't
return a non-null exit code if it matches but considering that there could
be more tests to perform after it anyhow this is probably not a big
problem.
Thanks,
VZ