Re: [lmi] wx_test_default_update.cpp

[Greg Chicares]

On 2015-03-04 13:31, Vadim Zeitlin wrote:
> On Fri, 23 Jan 2015 19:24:27 +0000 Greg Chicares <address@hidden> wrote:
> 
> GC> Let's do this:
> GC> (1) make sure "UseDOB" is checked (check it if it isn't); then
> GC> (2) set "DateOfBirth" to my birthdate, which you have divined.
> 
>  The first attached patch does this.

Committed 20150308T1908Z, revision 6123.

> GC> That's slightly more complicated than we might have hoped,
> 
>  If you look at the patch, you can see that it's indeed rather more
> complicated

I didn't have any trouble understanding your comments in the code.

>  Another small complication is that the "UseDOB" field, while being present
> in all skins, is not represented by the same control in all of them.
> Currently either a check or radio box (with 2 elements)

Probably we should change that for consistency. A checkbox seems to be
the best fit for a binary toggle.

> GC> >  Speaking of safety, the test specification doesn't say anything about
> GC> > preserving the original file, but should the test really modify it?
> GC>
> GC> Yes, really.
> 
>  Please notice that as a consequence of this decision, the test is "run
> once": i.e. while it runs successfully when it's launched the first time,
> it will fail, because there will be no changes to save in the defaults
> file, if it is run again. This seems not ideal to me, e.g. I could imagine
> a situation in which some other test fails because of some transient
> condition and the test suite needs to be run again -- but not this test
> will start (and keep) failing, preventing it from running to the
> completion. Of course, this can always be resolved by reinstalling lmi from
> scratch, and maybe the distribution tests are only supposed to be run in
> such pristine environment. But if not, we could avoid this problem by e.g.
> using some other fixed date for the DateOfBirth if it already has the value
> from (2) or maybe really toggling (instead of always enabling) UseDOB
> field, please let me know if you'd like me to propose patches doing this.

I'll ask Kim what she thinks.

> On Wed, 10 Dec 2014 21:28:40 +0000 Greg Chicares <address@hidden> wrote:
> 
> GC> On 2014-12-10 21:17, Greg Chicares wrote:
[...]
> GC>  /// Make sure the default input file can be opened, modified, and saved.
> GC>  ///
> GC> +/// Run this test only if the '--distribution' option is given.
> GC> +///
> 
>  And the second, much more trivial patch, implements the change above.

Applied 20150308T1918Z, revision 6124.