lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] Exclude "tags" from the concinnity check


From: Greg Chicares
Subject: Re: [lmi] Exclude "tags" from the concinnity check
Date: Wed, 29 Jul 2015 14:42:59 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0

On 2015-07-16 16:54, Vadim Zeitlin wrote:
> 
>  Here is a trivial patch to avoid giving an "exception" (but still existing
> with 0 exit code, strangely enough) when running "make check_concinnity"
> with a "tags" file being present in lmi directory. Since I've started using
> Vim plugin automatically generating the tags file if it's not present,
> getting this error became even more annoying as I now get it every time,
> even if I remove the tags file as it gets immediately regenerated.

Committed 20150729T1436Z, revision 6224.

>  FWIW I think it would be even better to classify the tags file as
> "ephemeral" and not "expungible" as the latter still results in a warning,
> but, surprisingly, ephemeral files are still check for coding rules,
> notably absence of tabs which are (and must be) present in the tags file,
> so my initial attempt to do it like this failed. If you think it's worth
> excluding the ephemeral files from all the checks, as it's already done for
> the binary and expungible files, I could modify the patch to do it like
> this, of course, just please let me know.

No thanks, it's fine the way it is. The difference between our viewpoints
is mainly semantic. The 'tags' file has properly been assigned to the
most suitable phylum, no matter how we name phyla. And, from my POV, if
a 'tags' file arose, I'd erase it, so to me it is "expungible".




reply via email to

[Prev in Thread] Current Thread [Next in Thread]