Re: [lmi] [PATCH] Integrate wxPdfDocument into lmi build system

[Vadim Zeitlin]

On Thu, 06 Aug 2015 19:58:28 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2015-07-24 00:21, Vadim Zeitlin wrote:
GC> [...]
GC> > Handle more options in portable wx-config.
GC> > 
GC> > More options than just --cxxflags and --libs are needed when wx-config is 
used
GC> > from the configure scripts of the libraries looking for the appropriate
GC> > version of wxWidgets to use, so make wx-config-portable usable in such
GC> > situations as well by handling calling it with more than one option at a 
time
GC> > and also processing more options.
GC> 
GC> Please help me understand this better.
GC> 
GC> I've applied all four of these patches in my local tree so that I can
GC> analyze the total effect. I don't see where the 'wx-config-portable'
GC> script is used for more than one option at a time.
...
GC> but I don't see where it's used with multiple arguments, or where it's
GC> ever used in 'install_wxpdfdoc.make'.

 install_wxpdfdoc.make runs wxPdfDocument configure which, as any
well-behaved configure script for an application using wxWidgets, uses
wx-config to find the version of wxWidgets satisfying the program
requirements. There is no real guarantee about which arguments would be
used but we can be more or less sure that the ones used in the patch will
be. Some configure scripts may use others as well, this is really just the
bare minimum required to make wxPdfDocument (which, admittedly, is rather
standard, so chances are that it will also work for other libraries in the
future) configure work.

GC> It's kind of too bad that 'make' doesn't support here-document syntax,
GC> but it's easy enough to extract the script from the makefile. I have
GC> only one difficulty understanding it: what's 'this_with_arg' for? Does
GC> it ensure that every multiple-argument invocation has --/c.*flags/ or
GC> --libs as its final argument? If so, why is that desirable?

 The purpose is simply to accept "--cxxflags libs" and "--libs libs" while
not accepting, say, "--basename libs" which wouldn't make sense. The real
wx-config outputs different things for --libs if the optional argument
specifying the libraries we want to link with is provided and, in
principle, the same can be the case for --cxxflags although in practice the
only difference is between "--cxxflags base" and "--cxxflags anything-else"
(or without the argument). There is no simple way to handle all the
possible arguments in wx-config-portable, so I just ignore them and always
return the standard set of compiler/linker flags. Again, this is obviously
incorrect in general, but is enough to make wxPdfDocument (and probably
other) configure script work.

GC> I don't see why, say, --rescomp is needed, or a do-nothing --host option
GC> is necessary

 Both are used by configure. The resource compiler will be typically needed
by any DLL to compile the resource file containing at least its version
information. Host option is used for cross-compilation support.

 Hope this answers your questions but if not, please let me know,
VZ