[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lmi] [PATCH] Avoid header.footer
From: |
Greg Chicares |
Subject: |
Re: [lmi] [PATCH] Avoid header.footer |
Date: |
Fri, 28 Aug 2015 15:43:05 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 |
On 2015-08-27 18:00, Vadim Zeitlin wrote:
> On Wed, 26 Aug 2015 19:57:52 +0000 Greg Chicares <address@hidden> wrote:
[...]
> GC> wxString const footer_html = "<p>" + header_.footer_ + "</p>";
> GC>
> GC> it's jarring to read "header_.footer_". Since you're the original author,
> GC> I'd like to ask you to decide how to handle this.
>
> IMHO the best and the simplest is to just just rename the badly named
> header_data struct [...patch provided...]
Committed 20150828T1541Z, revision 6272.
- Re: [lmi] Group premium quotes, (continued)
- Re: [lmi] Group premium quotes, Vadim Zeitlin, 2015/08/18
- [lmi] count_lines() [Was: Group premium quotes], Greg Chicares, 2015/08/19
- [lmi] Toolbar subtleties [Was: Group premium quotes], Greg Chicares, 2015/08/19
- [lmi] Miscellanea [Was: Group premium quotes], Greg Chicares, 2015/08/19
- Re: [lmi] Group premium quotes, Greg Chicares, 2015/08/26
- Re: [lmi] [PATCH] Fix headers display (was: Group premium quotes), Vadim Zeitlin, 2015/08/27