Re: [lmi] Saving and restoring window geometry

[Greg Chicares]

On 2018-05-02 14:08, Vadim Zeitlin wrote:
[...]
>  I've just merged and pushed the PR above, so the latest wxWidgets master
> (2a5aafb27419efb36999e24dbcc091eacea56286) contains the fix for the
> original problem and can be used for lmi: I've tested (which was trivially
> simple using the current install_wx.sh, proving that time spent on it
> wasn't wasted) the build using MinGW in my lmi VM.

Yes, that was definitely time well spent. In the build output, it's
nice to see the one-line log messages as a side effect:
  Previous HEAD position was e38866d3a6 Merge branch 'lzma'
  HEAD is now at 2a5aafb274 Fix missing tool in the overflow menu of 
wxAuiToolBar
as well as symbolic names such as tags:
   05d932d682..d19abf606d  WX_3_0_BRANCH -> origin/WX_3_0_BRANCH
   e905b94436..7fdd446cc8  master        -> origin/master

I wish git-fetch had a '--progress=summary' option that would show how
long it took and the number of bytes transferred. Maybe I should use
'--progress' and just filter out the ^M lines.

For the record, I did exactly this:
  /opt/lmi/src/lmi[0]$./install_wx.sh >../wx_log 2>&1
  /opt/lmi/src/lmi[0]$make $coefficiency --output-sync=recurse -f 
install_wxpdfdoc.make
  /opt/lmi/src/lmi[0]$make $coefficiency install check_physical_closure 2>&1 
|less -S
and everything seems to work as expected...except that, with 'wine',
if I
  unmaximize
  resize and move
  maximize
  exit
  reload
  unmaximize
then only the size is restored, not the position (it's moved to the upper
right corner).

Later I did:
  /opt/lmi/src/lmi[0]$./nychthemeral_test.sh 2>&1 | tee /tmp/lmi/logs/log | sed 
-f errors.sed
  /opt/lmi/bin[0]$wine ./wx_test --ash_nazg --data_path=/opt/lmi/data 
--pyx=only_new_pdf
and that revealed a dll-export problem, but that has nothing to do with
this wx upgrade--it just means I should have run that test before pushing
my preceding change...but that doesn't affect the production system.

It seems curious that libtiff notices lzma but not zlib:

 Support for external codecs:
  ZLIB support:                       no
  ...
  LZMA2 support:                      yes

but I don't actually care about that.