lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi] Goodbye to XSL-FO


From: Greg Chicares
Subject: [lmi] Goodbye to XSL-FO
Date: Sat, 13 Oct 2018 23:40:02 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0

I've purged XSL-FO from git..."and all I can think of...is...
Thank God and Greyhound you're gone". No more XSL! No more java!

We'll go through one more round of testing before releasing it into
production (at the end of next month, barring disaster). The only
remaining task is to make lmi read xz-compressed MST files. (We can
also reconsider whether we want to use
  C:\fop-0.20.5
as the default location for end users' PDF output files.)

Only twenty-seven "PDF !!" markers remain. Two were marked "TODO"
in the original:

$git show 0eec56ecf

@@ -62,7 +62,7 @@ std::string attribute::as_string() const
     if(!value_.empty())
         {
         s += "=";
-->      // TODO: Escape quotes.

@@ -130,7 +130,7 @@ void wx_table_generator::do_output_horz_separator(int x1, 
int x2, int y)
 
 void wx_table_generator::do_output_vert_separator(int x, int y1, int y2)
 {
-->  // TODO: add a possibility to have a thick border between the columns.

Vadim, do you see any need to act on those two, or even to retain the
markers? Escaping quotes sounds like a good idea; but I don't think we'll
ever actually want a thick border between columns, so I'm inclined to
purge that marker.

As for this in numeric_summary_table_cell::Draw()...

$git show d9ec2b90b

        // The horizontal coordinate is unused, but should always be zero.
        // PDF !! However, it isn't: this assertion fails when the
        // automated GUI test is run.
//      LMI_ASSERT(0 == x);
        (void)&x; // PDF !! Temporary workaround pending investigation.

Does it matter at all if the x coordinate is nonzero? I haven't looked
into it, but I suppose the numeric summary may be slightly indented;
do we care about that?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]