[Logs-devel] removed "no-" rules

[Vijay Lakshminarayanan]

Hi Jim

Here are my changes.  They aren't much and were also quite easy to do
(you've written it well).

I changed some AND clauses to WHEN's because they seemed more
appropriate since we no longer check for two things:

from:
(and (is-match-p) (not (is-no-match-p)) (do-stuff))

to:
(when (is-match-p) (do-stuff))

I've done similarly in the tests.  Where you had :NO-MATCH keywords,
I've plugged it into the :MATCH itself.  So now the tests pass and we
have the same number of tests.  (My originaly instinct had been to
remove the test case but it's better to remain, I thought.)

I have a question though.

Why have you been inconsistent with checking if MATCH, DELETE-RULE etc?

For instance, in RULE-MATCHES-P in rule.lisp, you say

(cond ((functionp match) (funcall match message))

but in CHECK-RULE you say

(when delete-rule
  (when (funcall delete-rule message)

Originally I'd thought the former was the right thing to do but now I
think the second is better.  This way we can use #'foo and 'foo
interchangeably.

Is there any reason for the inconsistency?

Cheers
Vijay

rule.lisp.diff
Description: Text Data

ruleset.lisp.diff
Description: Text Data

tests.lisp.diff
Description: Text Data