[lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, updated. master_at_STABLE-2_0_0-1081-g0527c1b

[Simon Goldschmidt]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "lwIP - A Lightweight TCPIP stack".

The branch, master has been updated
       via  0527c1bdf5d7208a2bb83a27f9e458f68e798721 (commit)
       via  df563e74f92bcaee8f6f0e2c4497f7f77b0e61c5 (commit)
       via  892e30d8c10cccba5594fa75a6dc12d4d610cecf (commit)
       via  4c90858482bde72ba7ff92c69a660694383f2198 (commit)
       via  82483073f09916cc81e113d46d9f41829a69f334 (commit)
       via  ba270c2414142c5474349c32338d04921bbc6892 (commit)
      from  920ee2d07ee50d24e8d1fe01c207587f26d07a53 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0527c1bdf5d7208a2bb83a27f9e458f68e798721
Author: Axel Lin <address@hidden>
Date:   Tue Dec 5 21:51:13 2017 +0800

    apps/smtp: Avoid NULL pointer dereference in smtp_send_body_data_handler
    
    Move the code to have NULL test before dereference.
    
    Signed-off-by: Axel Lin <address@hidden>
    Signed-off-by: goldsimon <address@hidden>

commit df563e74f92bcaee8f6f0e2c4497f7f77b0e61c5
Author: Axel Lin <address@hidden>
Date:   Tue Dec 12 21:52:08 2017 +0800

    ip4: Fix IPH_OFFSET_BYTES macro
    
    Current code only works if the argument happen to be named as fraghdr,
    fix it.
    
    Signed-off-by: Axel Lin <address@hidden>
    Signed-off-by: goldsimon <address@hidden>

commit 892e30d8c10cccba5594fa75a6dc12d4d610cecf
Author: Axel Lin <address@hidden>
Date:   Wed Dec 13 16:35:00 2017 +0800

    ip4_reass: Use IPH_HL_BYTES instead of open coded
    
    Signed-off-by: Axel Lin <address@hidden>
    Signed-off-by: goldsimon <address@hidden>

commit 4c90858482bde72ba7ff92c69a660694383f2198
Author: Axel Lin <address@hidden>
Date:   Wed Dec 13 20:15:23 2017 +0800

    ip4_reass: Fix build error when IP_REASS_CHECK_OVERLAP=0
    
    The goto freepbuf code path is also used when IP_REASS_CHECK_OVERLAP=0.
    Thus remove #if IP_REASS_CHECK_OVERLAP around the freepbuf label to fix
    below build error:
    
    cc -g -Wall -DLWIP_DEBUG -pedantic -Werror -Wparentheses -Wsequence-point 
-Wswitch-default -Wextra -Wundef -Wshadow -Wpointer-arith -Wcast-qual 
-Wc++-compat -Wwrite-strings -Wold-style-definition -Wcast-align 
-Wmissing-prototypes -Wredundant-decls -Wnested-externs -Wunreachable-code 
-Wuninitialized -Wlogical-op -I. -I../../.. -I../../../../lwip/src/include 
-I../../../ports/unix/port/include -I../../../../mbedtls/include 
-Wno-redundant-decls -DLWIP_HAVE_MBEDTLS=1 -c 
../../../../lwip/src/core/ipv4/ip4_frag.c
    ../../../../lwip/src/core/ipv4/ip4_frag.c: In function
    ‘ip_reass_chain_frag_into_datagram_and_validate’: 
../../../../lwip/src/core/ipv4/ip4_frag.c:412:7: error: label ‘freepbuf’ 
used but not defined
           goto freepbuf;
           ^~~~
    
    Signed-off-by: Axel Lin <address@hidden>
    Signed-off-by: goldsimon <address@hidden>

commit 82483073f09916cc81e113d46d9f41829a69f334
Author: goldsimon <address@hidden>
Date:   Sun Dec 17 22:13:09 2017 +0100

    sntp_send_request: assert that argument 'server_addr' != NULL

commit ba270c2414142c5474349c32338d04921bbc6892
Author: Axel Lin <address@hidden>
Date:   Fri Dec 15 14:47:52 2017 +0800

    apps/sntp: Use ip_addr_copy to save server address
    
    Use ip_addr_copy instead of ip_addr_set to avoid NULL test for
    &sntp_last_server_address. This fixes build warning when
    SNTP_CHECK_RESPONSE>=1 && LWIP_IPV4=1 && LWIP_IPV6=1.
    
    In file included from ../../../../lwip/src/include/lwip/apps/sntp.h:41:0,
                     from ../../../../lwip/src/apps/sntp/sntp.c:52:
    ../../../../lwip/src/apps/sntp/sntp.c: In function ‘sntp_send_request’:
    ../../../../lwip/src/include/lwip/ip_addr.h:105:58: error: the comparison 
will always evaluate as ‘true’ for the address of 
‘sntp_last_server_address’ will never be NULL [-Werror=address]
     #define IP_SET_TYPE(ipaddr, iptype)     do { if((ipaddr) != NULL) { 
IP_SET_TYPE_VAL(*(ipaddr), iptype); }}while(0)
                                                              ^
    ../../../../lwip/src/include/lwip/ip_addr.h:157:36: note: in expansion of 
macro ‘IP_SET_TYPE’
     #define ip_addr_set(dest, src) do{ IP_SET_TYPE(dest, IP_GET_TYPE(src)); 
if(IP_IS_V6(src)){ \
                                        ^~~~~~~~~~~
    ../../../../lwip/src/apps/sntp/sntp.c:549:5: note: in expansion of macro 
‘ip_addr_set’
         ip_addr_set(&sntp_last_server_address, server_addr);
         ^~~~~~~~~~~
    
    Signed-off-by: Axel Lin <address@hidden>
    Signed-off-by: goldsimon <address@hidden>

-----------------------------------------------------------------------

Summary of changes:
 src/apps/smtp/smtp.c        | 3 ++-
 src/apps/sntp/sntp.c        | 5 ++++-
 src/core/ipv4/ip4_frag.c    | 4 +---
 src/include/lwip/prot/ip4.h | 2 +-
 4 files changed, 8 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
lwIP - A Lightweight TCPIP stack