[lwip-devel] [patch #5865] Fix missing lwip directory in socket.h including path

[Frédéric Bernon]

Follow-up Comment #6, patch #5865 (project lwip):

Hi,


I think that the patch is good, and that tcp.h must stay here to reach some
options defines like TCP_NODELAY, TCP_KEEPALIVE, .... If yo really want to
remove it, think to add all necessary defines in sockets.h. 

Note that because some others include like opt.h and ip_addr.h are necessary,
I don't understand why tcp.h will cause a problem...
 
And you will have to maintain a compatible table like SO_ options (in
sockets.h) and SOF_ options (in ip.h), like this example :
#define  SO_BROADCAST   0x0020 /* permit sending of broadcast msgs */
#define SOF_BROADCAST (u16_t)0x0020U    /* permit sending of broadcast msgs
*/

And to my point of view, it's not very nice...


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?5865>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/