[lwip-devel] [task #6833] netif.h: add netif->poll() / create netif_poll_all() to simplify porting

[Jonathan Larmour]

Follow-up Comment #1, task #6833 (project lwip):

Just my opinion, but I don't see any real value in this to warrant extra
code/data. In the majority of cases, this would just convert a native
driver's poll in a main outer loop to an API call that just does exactly the
same thing, but now has to conform to an API and fit into the netif
abstraction.

So instead of calling something like e.g.:
  while (1) {
    pbuf = myeth_driver_poll();
    if (pbuf)
      tcpip_ethinput(pbuf, netif_eth0);
  }

you now would call netif_poll_all(), which would have to call
myeth_driver_poll() - a function which does the same operation.

If we want to make this area easier to use, an example would be better than
an API change. I don't think it's that difficult to use anyway.

As I said, just my opinion though.


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?6833>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/