[lwip-devel] [bug #24032] pbuf realloc wander over the end of a linked list

[Simon Goldschmidt]

Follow-up Comment #2, bug #24032 (project lwip):

The second part of the patch (for pbuf_header) is simply wrong: you return 0
(= succeeded) when trying to take more of the pbuf than it has -> if anything,
returning 1 would be the right thing to do! (which is done by the LWIP_ERROR
you commented out)

As to the first part, of course Jonathan is right: this should never happen!
Nevertheless, ignoring this isn't good coding style - at least an assert
should be added which points you to the error instead of dereferencing a NULL
pointer (which I'll do now).

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?24032>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/