lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [bug #50498] tcp: do not keep sending SYNs when getting ACK


From: Simon Goldschmidt
Subject: [lwip-devel] [bug #50498] tcp: do not keep sending SYNs when getting ACKs
Date: Thu, 9 Mar 2017 07:10:16 -0500 (EST)
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Follow-up Comment #1, bug #50498 (project lwip):

I'm OK with the change, but I don't see how the loop could be endless given
that 'tcp_rexmit_rto()' increases 'pcb->nrtx' and 'tcp_slowtmr()' checks for
TCP_SYNMAXRTX.

Wait, I see:
1) 'pcb->nrtx' can overflow if 'tcp_rexmit_rto()' is called too often and
2) 'tcp_slowtmr()' checks for '==' instead of '>='

We might want to fix these anyway since 'pcb->nrtx' is used as an offset into
the 'tcp_backoff' array...

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?50498>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]