[lwip-devel] [bug #50694] TX exist more pbufs after enable LWIP_NETIF_TX_SINGLE_PBUF

[Simon Goldschmidt]

Update of bug #50694 (project lwip):

                  Status:            Works For Me => None                   

    _______________________________________________________

Follow-up Comment #7:

Ah, well I haven't tested that setting, sorry.

Forget the code in comment #5, pbuf_coalesce cannot be used here because 'p'
must not be freed (the ref belongs to the caller).

I've added 'pbuf_alloc_copy' for that and clarified LWIP_NETIF_TX_SINGLE_PBUF
int opt.h:

if (p->next != NULL) {
  struct pbuf *q = pbuf_alloc_copy(PBUF_RAW, PBUF_RAM, p);
  if (q == NULL) {
    return ERR_MEM;
  }
  /* ATTENTION: do NOT free the old 'p' as the ref belongs to the caller! */
  p = q;
}


We still could fix this bug here by not chaining pbufs to segments. I'd be
happy to get a patch for that :-)

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?50694>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/