lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #9339] mdns: support for deleting responder services


From: David GIRAULT
Subject: [lwip-devel] [patch #9339] mdns: support for deleting responder services and searching services on network
Date: Fri, 12 May 2017 10:05:10 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.96 Safari/537.36

Follow-up Comment #11, patch #9339 (project lwip):

Nice to have patch #1 already pushed.

Now for the 2nd patch:

- for coding style, what kind of style error? have you a .astylerc
configuration I can use?

- the stop function should be called from the result_fn callback, where the
mdns_request pointer is known.
the result_fn callback is called at least once. the first call is synchronous
during the call to `mdns_search_service` before it return and allow
application to store the `mdns_request` pointer. this allow application to
call stop fnuction later if no answer were received (timeout handling done by
app).

- mdns code in dns.c don't allow browsing the network for services like this
patch does. it only allow doing an A or AAAA request. as you can see,
mdns_search_service() does a PTR request. additionnaly, all answer RR included
in all response received are sent to application provided callback.
The last answer RR in a received frame is flagged to allow application to
detect multiple responses.

- request sent by dns.c are flagged so response are unicast. mdns request sent
by my patch result in multicast response, so received by mdns multicast udp
socket itself.

- mdns.c already provided most of decoding of dns frame and has support for
PTR, SRV, and TXT RR.

- dns_gethostbyname() may be still used to search for '.local' domain.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?9339>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]