[lwip-devel] [bug #52763] mdns: move data off the stack and dynamically allocate data.

[Erik Ekman]

Follow-up Comment #4, bug #52763 (project lwip):

Nice to see progress. Some more comments:

For LWIP_ERROR, I think this is the minimal definition:

#define LWIP_ERROR(message, expression, handler) do { if (!(expression)) {
handler; }} while(0)

Asserts and the logging message can be ignored, but not the handler as I
understand it.

realloc isnt supported by the lwIP memory abstraction, it was renamed mem_trim
since it could only shrink the allocation - so we needed to stop using realloc
anyway.

Please check if test/unit/mdns/test_mdns.c needs to be updated as well  - you
can run it from ports/unix/check in the contrib repo.

You don't need the semicolon after the 'err:' label.


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?52763>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/