[lwip-devel] [bug #53325] NetBIOS Responder should respond to "*" names for lwIP 2.0.3

[Jens Nielsen]

Follow-up Comment #6, bug #53325 (project lwip):

Some notes:

* First part of struct netbios_answer is afaik same as struct
netbios_name_hdr, reuse (like struct netbios_resp does) or use the same member
names or at least the same code style
* The pbuf_free(p); at end of netbiosns_recv() is now inside if (netif_default
!= NULL) so it leaks if netif_default == NULL
* One memcpy should be MEMCPY
* Move size_t i; declaration to beginning of netbiosns_set_name()
* When doing the upper case conversion you might as well skip the memcpy
before and do toupper directly from 'hostname'
* The upper case enforcement doesn't apply if NETBIOS_LWIP_NAME is defined (if
that's desired)

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?53325>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/