[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [bug #53396] unit tests build broken for msvc
From: |
Joel Cunningham |
Subject: |
[lwip-devel] [bug #53396] unit tests build broken for msvc |
Date: |
Wed, 21 Mar 2018 17:11:59 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0 |
Update of bug #53396 (project lwip):
Status: None => Fixed
Assigned to: None => jcunningham
Open/Closed: Open => Closed
_______________________________________________________
Follow-up Comment #2:
So it turned out to be a little stranger than I had thought.
For lwIP_Unittests, opt.h is already being included first before cc.h. I'm
not sure where, but I verified it by testing the following in cc.h:
#ifdef LWIP_HDR_OPT_H
#error how is this in here?
#endif
And the error is present
For lwIP_Tests, opt.h is not included first (as expected).
So for now, I've just used
#if !defined(LWIP_TESTMODE) || !LWIP_TESTMODE
to guard:
void lwip_win32_platform_diag(const char *format, ...);
#define LWIP_PLATFORM_DIAG(x) lwip_win32_platform_diag x
(see commit 194dee99568eebda3b2deeb8cce19ca01095816e)
Both builds are working! We could do some additional cleanup if opt.h being
included first before cc.h for lwIP_Unittests is undesirable longer term
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/bugs/?53396>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/