[lwip-devel] [bug #54228] dhcp.c, 1685: extra check

[Andrey Vinogradov]

URL:
  <http://savannah.nongnu.org/bugs/?54228>

                 Summary: dhcp.c, 1685: extra check
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: andreyvinogradov
            Submitted on: Пн. 02 июля 2018 09:23:17
                Category: DHCP
                Severity: 3 - Normal
              Item Group: Compiler Warning
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None
            lwIP version: git head

    _______________________________________________________

Details:


u16_t offset;
u16_t offset_max;
...
if ((offset < offset_max) && offset_max) {
...
}

if offset_max = 0, it means that offset < 0. So should be just

if (offset < offset_max) {
...
}
or some bug




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?54228>

_______________________________________________
  Сообщение отправлено по Savannah
  https://savannah.nongnu.org/