[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-users] [PATCH] cleanup and simplify contrib/ports/unix/proj/minima
From: |
wk |
Subject: |
[lwip-users] [PATCH] cleanup and simplify contrib/ports/unix/proj/minimal/ |
Date: |
Sat, 18 Apr 2009 01:04:26 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Hello,
Those patches cleanup and simplify the example from
contrib/ports/unix/proj/minimal/.
I considered these changes useful while learning about lwip by reading the
example program.
1/3: tmr_intervals.patch
Use the lwip constants ARP_TMR_INTERVAL and IP_TMR_INTERVAL instead of
hardcoded values. The program already uses the constants TCP_FAST_INTERVAL and
TCP_SLOW_INTERVAL. This also changes the ARP timer value from hardcoded 20s
to the lwip default of 5s.
2/3: ethernet_input.patch
The program has own code that does just what ethernet_input() does.
Use ethernet_input() instead.
3/3: pbuf_cat.patch
The program uses pbuf_chain() where pbuf_cat() would be more appropriate.
This makes freeing the buffer (chain) unnecessarily complicated.
Use pbuf_cat() and simplify freeing.
I would be pleased if someone with CVS write access could tell me if those
patches are suitable for inclusion and do so if appropriate.
Bye,
Wolfgang Koebler
tmr_intervals.patch
Description: Text Data
ethernet_input.patch
Description: Text Data
pbuf_cat.patch
Description: Text Data
- [lwip-users] [PATCH] cleanup and simplify contrib/ports/unix/proj/minimal/,
wk <=