[lwip-users] contrib/ports/unix/proj/minimal/mintapif.c uses a buggy MAC Address

[wk]

Hello,

Not very important, but I stumbled over it:
contrib/ports/unix/proj/minimal/mintapif.c uses a buggy MAC Address. It uses 
01-02-03-04-05-06, yet the two lower bits of the first octet have special 
meanings (see http://en.wikipedia.org/wiki/MAC_address). 01 means the MAC is 
a globally unique multicast address. However the address has not been acquired
from the IEEE, so it is "locally administered". And obviously it should be a 
unicast address. So, 02-02-03-04-05-06 would be a suitable address, so 
replacing l.93 (in low_level_init):
<  mintapif->ethaddr->addr[0] = 1;
by
>  mintapif->ethaddr->addr[0] = 2; /* addr[0]&3=2: localy administered unicast 
> */
would fix this minor glitch.

(Alternatively it could be replaced by another systematic address, like 
12-34-56-78-9a-bc, or a more random and (thus more unique) address like 
ee-0e-af-47-08-4b)

Bye,
Wolfgang Koebler