lynx-dev Lynx 2.8 - VMS build problems (long)

[Liam Davis]

I have recently acquired Lynx 2.8 and built it on OpenVMS 6.2 (Alpha) using 
DECC V5.7

There were some problems with the build and MMS files, which are listed below, 
along with
suggested solutions in the form of difference listings.

[I have removed the common context lines, and editted the line number prefix 
fields in some
cases to remove extra spaces in order to reduce the line length.]

Top-level DESCRIP.MMS file:
---------------------------
This uses nested MMS commands to build everything; however it does not pass on 
any MMS
qualifiers, so one cannot (e.g.) use /FROM to insist on a full rebuild.

To solve this, replace

$(MMS) etc
by
$(MMS) $(MMSQUALIFIERS) etc

This then allows the use of /FROM /IGNORE /NOACTION etc

************
File DISK09:[LYNX.LYNX2-8]DESCRIP.MMS;2
100 $(MMS) $(MMSQUALIFIERS) /Description = [-.VMS]DESCRIP.MMS /Macro = 
($(TCPM)=1, DEC_C=1)
Library
103 $(MMS) $(MMSQUALIFIERS) /Description = [-.VMS]DESCRIP.MMS /Macro = 
($(TCPM)=1, GNU_C=1)
Library
105 $(MMS) $(MMSQUALIFIERS) /Description = [-.VMS]DESCRIP.MMS /Macro = 
($(TCPM)=1) Library
******
File DISK09:[LYNX.LYNX2-8]DESCRIP.MMS;1
100 $(MMS) /Description = [-.VMS]DESCRIP.MMS /Macro = ($(TCPM)=1, DEC_C=1) 
Library
103 $(MMS) /Description = [-.VMS]DESCRIP.MMS /Macro = ($(TCPM)=1, GNU_C=1) 
Library
105 $(MMS) /Description = [-.VMS]DESCRIP.MMS /Macro = ($(TCPM)=1) Library
************
************
File DISK09:[LYNX.LYNX2-8]DESCRIP.MMS;2
113 $(MMS) $(MMSQUALIFIERS) /Macro = ($(TCPM)=1, DEC_C=1) Lynx
116 $(MMS) $(MMSQUALIFIERS) /Macro = ($(TCPM)=1, GNU_C=1) Lynx
118 $(MMS) $(MMSQUALIFIERS) /Macro = ($(TCPM)=1) Lynx
******
File DISK09:[LYNX.LYNX2-8]DESCRIP.MMS;1
113 $(MMS) /Macro = ($(TCPM)=1, DEC_C=1) Lynx
116 $(MMS) /Macro = ($(TCPM)=1, GNU_C=1) Lynx
118 $(MMS) /Macro = ($(TCPM)=1) Lynx
************
************
File DISK09:[LYNX.LYNX2-8]DESCRIP.MMS;2
127 $(MMS) $(MMSQUALIFIERS) /Description = [-.VMS]DESCRIP.MMS clean
******
File DISK09:[LYNX.LYNX2-8]DESCRIP.MMS;1
127 $(MMS) /Description = [-.VMS]DESCRIP.MMS clean
************

Number of difference sections found: 3
Number of difference records found: 16

DIFFERENCES /IGNORE=()/MERGED=1/OUTPUT=DISK09:[LYNX.LYNX2-8]DESCRIP.DIFF;1-
    DISK09:[LYNX.LYNX2-8]DESCRIP.MMS;2-
    DISK09:[LYNX.LYNX2-8]DESCRIP.MMS;1


The lower level MMS files also need to be amended to add the correct include 
directories for
DEC-C. Difference listings follow.

************
File DISK09:[LYNX.LYNX2-8.SRC]DESCRIP.MMS;2
157 CFLAGS = (TCPFLAGS) $(CFLAGS)/Include=([],[-],[.chrtrans], 
[-.WWW.Library.Implementation])
******
File DISK09:[LYNX.LYNX2-8.SRC]DESCRIP.MMS;1
157 CFLAGS = (TCPFLAGS) $(CFLAGS)/Include = ([-], [.chrtrans], 
[-.WWW.Library.Implementation])
************

Number of difference sections found: 1
Number of difference records found: 1

DIFFERENCES /IGNORE=()/MERGED=1/OUTPUT=DISK09:[LYNX.LYNX2-8]SRC.DIFF;1-
    DISK09:[LYNX.LYNX2-8.SRC]DESCRIP.MMS;2-
    DISK09:[LYNX.LYNX2-8.SRC]DESCRIP.MMS;1


************
File DISK09:[LYNX.LYNX2-8.WWW.LIBRARY.VMS]DESCRIP.MMS;2
   82   INCLUDES=/include=([-.Implementation],[---.src],[---])
   83   
   86   DCFLAGS = /NoMember /Warning=(disable=implicitfunc)  $(INCLUDES)
******
File DISK09:[LYNX.LYNX2-8.WWW.LIBRARY.VMS]DESCRIP.MMS;1
   84   DCFLAGS = /NoMember /Warning=(disable=implicitfunc)
************
************
File DISK09:[LYNX.LYNX2-8.WWW.LIBRARY.VMS]DESCRIP.MMS;2
   94   CFLAGS = $(DEBUGFLAGS) /Define=($(EXTRADEFINES), UCX) $(INCLUDES)
******
File DISK09:[LYNX.LYNX2-8.WWW.LIBRARY.VMS]DESCRIP.MMS;1
   92   CFLAGS = $(DEBUGFLAGS) /Define=($(EXTRADEFINES), UCX)
************

Number of difference sections found: 2
Number of difference records found: 6

DIFFERENCES /IGNORE=()/MERGED=1/OUTPUT=DISK09:[LYNX.LYNX2-8]VMS.DIFF;2-
    DISK09:[LYNX.LYNX2-8.WWW.LIBRARY.VMS]DESCRIP.MMS;2-
    DISK09:[LYNX.LYNX2-8.WWW.LIBRARY.VMS]DESCRIP.MMS;1


Compilation problems (caused by extra checking in DECC V5.7):
--------------------

The procedure VMSSignal does not actually return a value, and so needs to be 
defined as
void, not void *

This affects LYsignal.h, LYCurses.c, LYCurses.h

            return;
............^
%CC-W-NORETURNVAL, The function "VMSsignal" returns a value, but no value is 
given in this
return statement.
at line number 1535 in file DISK09:[LYNX.LYNX2-8.SRC]LYCURSES.C;1

            return;
............^
%CC-W-NORETURNVAL, The function "VMSsignal" returns a value, but no value is 
given in this
return statement.
at line number 1543 in file DISK09:[LYNX.LYNX2-8.SRC]LYCURSES.C;1

            return;
............^
%CC-W-NORETURNVAL, The function "VMSsignal" returns a value, but no value is 
given in this
return statement.
at line number 1560 in file DISK09:[LYNX.LYNX2-8.SRC]LYCURSES.C;1

DECC V5.7 is very picky: even though the dummy parameter in the call to 
longname is not used,
it complains that the pointer has not been set.

    longname(dummy, term);
.............^
%CC-W-UNINIT1, The scalar variable "dummy" is fetched but not initialized.
at line number 948 in file DISK09:[LYNX.LYNX2-8.SRC]LYCURSES.C;1


Defining dummy as char[4] instead solves the problem.



BUILD.COM
---------
The main BUILD.COM command file could be improved to handle invalid input 
better; for example
it does not detect if the user types a number out of range, nor does it detect 
an invalid
parameter.

The following difference listing includes both:
- detection of invalid parameter P1
- default batch with no parameter = MULTINET
- check that TCP/IP agent is valid

************
File DISK09:[LYNX.LYNX2-8]BUILD.COM;1
   89   $ if agent .eq. 1 .or. agent .eqs. "" .or. p1 .eqs. "MULTINET" then -
   90       option = "MULTINET"
******
File DISK09:[LYNX.LYNX2-8]BUILD1.COM;5
   89   $ if agent .eq. 1 .or. agent .eqs. "" .or. p1 .eqs. "" .or. p1 .eqs. 
"MULTINET" then -
   90       option = "MULTINET"
************
************
File DISK09:[LYNX.LYNX2-8]BUILD.COM;1
   97   $ if option .eqs. "TCPWARE"
******
File DISK09:[LYNX.LYNX2-8]BUILD1.COM;5
   97   $ if option .eqs. ""
   98   $ then
   99   $    write sys$output "TCP/IP agent could not be determined"
  100   $    exit 18
  101   $ endif
  102   $
  103   $ if option .eqs. "TCPWARE"
************

Number of difference sections found: 2
Number of difference records found: 7

DIFFERENCES /IGNORE=()/MERGED=1/OUTPUT=DISK09:[LYNX.LYNX2-8]BUILD.DIFF;1-
    DISK09:[LYNX.LYNX2-8]BUILD.COM;1-
    DISK09:[LYNX.LYNX2-8]BUILD1.COM;5

-- 
Liam Davis
address@hidden