lynx-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: lynx-dev Pages without titles unreachable on historylist


From: Leonid Pauzner
Subject: Re: lynx-dev Pages without titles unreachable on historylist
Date: Sat, 12 Dec 1998 13:30:29 +0300 (MSK)

11-Dec-98 22:08 Alchemist Matt wrote:
> Hi,

>       I'm using version 2.8.2dev.8 of Lynx and just noticed a
> problem when browsing pages and choosing the history list (backspace key).
> Pages without titles are numbered in the list and their URL displayed, but
> they cannot be selected (via arrow keys and Enter) for movement to.  As an
> example, browse some pages, then go to:
>       http://www.netguide.com/happyholidays/
> and browse some more pages.  Now go to the history list, and you'll see
> something like the following:

>                     History Page (Lynx Version 2.8.2dev.8)

This problem in LYHistory.c and belongs to all versions of Lynx
(I check 2.6 and it is also in).
No problem with pages without titles, the problem for those
that say notitle explicitely as in the requested page:
<TITLE></TITLE>

"Visited links" work around it and say "[no title]"
but "History page" fails. We could not bookmark this page either.
Comparing LYShowVisitedLinks() and showhistory() gives the following fix:

diff -u old/lyhistor.c ./lyhistor.c
--- old/lyhistor.c      Thu Dec  3 10:28:20 1998
+++ ./lyhistor.c        Sat Dec 12 13:00:50 1998
@@ -391,7 +391,7 @@
         *  The number of the document in the hist stack,
         *  its title in a link, and its address. - FM
         */
-       if (history[x].title != NULL) {
+       if (history[x].title != NULL && *history[x].title != '\0') {
            StrAllocCopy(Title, history[x].title);
            LYEntify(&Title, TRUE);
        } else {


But this is not good because a space between <TITLE> </TITLE>
will force both Visited and History to fail.
We should check for any non-space character instead
(like KW does in bookmark code recently or just LYTrimTrailing or so).

Leonid.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]