Re: lynx-dev 2.8.3dev.2 patch 2 - misc.

[Leonid Pauzner]

22-Jun-99 01:19 Klaus Weide wrote:

> * Entify strings when adding them to LYNXMESSAGES: stack.

That messages also available for LYstatusline_messages_on_exit()
called from mainloop, they will be written to stdout (not HTML format).
Strings should be entified in LYshow_statusline_messages() directly
(small overhead with copying temp string but this function is not something
called a lot).


> * More general checking in postoptions - `lynx LYNXOPTIONS:foo'
>   now doesn't crash.

> Index: lynx2-8-3/src/LYOptions.c
> --- lynx2-8-3.old/src/LYOptions.c Mon, 21 Jun 1999 00:31:29 -0500
> +++ lynx2-8-3/src/LYOptions.c Mon, 21 Jun 1999 22:55:36 -0500
> @@ -3553,17 +3553,22 @@
>       return(NULLFILE);
>      }

> +    data = break_data(newdoc->post_data);
> +
> +    if (!data) {
> +     int status;

> +     HTAlwaysAlert("Unexpected way of accessing", newdoc->address);

Do you mean every call of LYNXOPTIONS:foo with no post data is unexpected
way of accessing?
IMHO, LYNXOPTIONS:/ is the standart way of accessing forms options menu
(see LYK_OPTIONS in mainloop, was changed a month ago or so).


>      /*-------------------------------------------------
>       * kludge gen_options() call:
>       *--------------------------------------------------*/
> +     status = gen_options(&newdoc->address);
> +     if (status != NORMAL) {
> +         FREE(newdoc->address);
> +         return(status);
> +     }

> -    if (strstr(newdoc->address, "LYNXOPTIONS:/") && !newdoc->post_data) {
> -     int status = gen_options(&newdoc->address);
> -     if (status == NOT_FOUND)
> -         return(NOT_FOUND);
> -
> -     /* exit to getfile() cyrcle */
> +     /* exit to getfile() cycle */
>       WWWDoc.address = newdoc->address;
>       WWWDoc.post_data = newdoc->post_data;
>       WWWDoc.post_content_type = newdoc->post_content_type;
> @@ -3575,9 +3580,6 @@
>           return(NOT_FOUND);
>       return(NORMAL);
>      }
> -
> -
> -    data = break_data(newdoc->post_data);

>      for (i = 0; data[i].tag != NULL; i++) {
>       /*

> Index: lynx2-8-3/src/LYHistory.c
> --- lynx2-8-3.old/src/LYHistory.c Tue, 08 Jun 1999 13:19:59 -0500
> +++ lynx2-8-3/src/LYHistory.c Mon, 21 Jun 1999 22:56:03 -0500
> @@ -772,6 +772,7 @@
>      if (message != NULL) {
>       char *temp = NULL;
>       HTSprintf(&temp, message, (argument == 0) ? "" : argument);
> +     LYEntify(&temp, TRUE);
>       to_stack(temp);
>      }
>  }
> @@ -782,6 +783,7 @@
>      if (message != NULL) {
>       char *temp = NULL;
>       StrAllocCopy(temp, message);
> +     LYEntify(&temp, TRUE);
>       to_stack(temp);
>      }
>  }