[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: lynx-dev patch - "JUSTIFY"

From: mattack
Subject: Re: lynx-dev patch - "JUSTIFY"
Date: Wed, 14 Jul 1999 11:21:32 -0700 (PDT)

On Wed, 14 Jul 1999, Philip Webb wrote:
>On Bastille Day, Vlad Harchev wrote: 
>> On Wed, 14 Jul 1999, Klaus Weide wrote:
>>> We agree the current/ancient implementation of 'style stack' is incomplete.
>>> its use in HTML.c is inconsistent, a mess & nearly incomprehensible.
>>> So I don't blame you for working around it a/a cleaning it up.
>>> But working-around for a specific purpose makes things more complicated
>>> & is probably how the mess came into existence in the first place.
>> Yes, seems lynx development is turned into lynx hacking IMO:
>> code is badly documented, nobody wishes to spent a lot of time on it.
>i'm delighted to see two of our senior programmers agreeing
>on something i've been grumbling about for a long time.
>>> Cleaning up style usage in HTML.c isn't really revolutionary
>>> and wouldn't have immediately noticeable effects
>>> so it's not an attractive project, but *someone* should do it...
>> Yes, there are a lot of things in lynx someone should do..
>what it probably needs is more mutual encouragement
>when people do occasionally undertake the more mundane tasks,

I realize this is a religious issue, but what I found most difficult about
reading the Lynx code is the brace style.

There are many different ways of implementing the following (and I realize I
do it differently from others, but will conform to slightly different
styles when dealing with other people's code), but simply matching up
paired curly brackets would help readability a lot.

  if (LYNoCore) {

that's a very very small example, and obviously is readable.  But in 
some of those switch statements within switch statements, it's basically
impossible to figure out where the heck you are, mostly because of not
being able to simply match scopes vertically via opening and closing curly

I'm not even sure this is the kind of 'style' you're talking about, but
it sure made my very tiny patches harder to do.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]