[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

lynx-dev [PATCH 2.8.3.dev6] patch that will prevent returning to the pre

From: Vlad Harchev
Subject: lynx-dev [PATCH 2.8.3.dev6] patch that will prevent returning to the previous documen if Key-Left was pressed at the column 0 of the textfield
Date: Thu, 12 Aug 1999 07:05:33 +0500 (SAMST)

 This patch will prevent annoying behaviour of lynx when pressing extra
Key-Left in textfield - activating the previous document.
 As I remember, several people considered this as useful improvement.
 This patch prevents this annoying behaviour by default (the behaviour is now
controlled by variable 'textfield_stop_at_left_edge' - when it's FALSE, the
old behaviour is in effect, but I made it TRUE by default).

 I don't know, whether such functionality should be configurable (ie whether
to provide commandline options and lynx.cfg setting for controlling it) - but
anyway I will be unable to invent the name for them - so all lynx-devers,
start thinking on it, if somebody needs old behaviour... If the names will be
decided, ask some other lynx developer to add support for that command line
option and lynx.cfg setting - this will require 2 lines of code (1 for
commandline option, 1 for lynx.cfg setting).

 If nobody considers old behaviour useful, then the patch is ready for
integration (and new behaviour will be unconditionally in effect).

 There is a 3rd way - make the value of the 'textfield_stop_at_left_edge'
controllable via CPP define in - this will eliminate the need for
inventing the descriptive and short names for commandline option and lynx.cfg

 Best regards,

diff -ru old/LYForms.c fixed/LYForms.c
--- old/LYForms.c       Sat Jul 31 04:38:15 1999
+++ fixed/LYForms.c     Thu Aug 12 06:45:30 1999
@@ -627,7 +627,10 @@
                        c = HTConfirmDefault(PREV_DOC_QUERY, NO);
                    if (c == YES) {
-                       return(ch);
+                       if (!textfield_stop_at_left_edge)
+                           return(ch);
+                       else
+                           goto again;
                    } else {
                        if (form->disabled == YES)
diff -ru old/LYGlobalDefs.h fixed/LYGlobalDefs.h
--- old/LYGlobalDefs.h  Wed Aug 11 19:07:41 1999
+++ fixed/LYGlobalDefs.h        Thu Aug 12 06:45:52 1999
@@ -450,4 +450,5 @@
 extern int LYsb_end;
+extern BOOL textfield_stop_at_left_edge;
 #endif /* LYGLOBALDEFS_H */
diff -ru old/LYMain.c fixed/LYMain.c
--- old/LYMain.c        Thu Aug 12 06:50:59 1999
+++ fixed/LYMain.c      Thu Aug 12 06:49:09 1999
@@ -455,6 +455,8 @@
 PUBLIC BOOL sticky_inputs = TRUE;
+PUBLIC BOOL textfield_stop_at_left_edge=TRUE;
 PUBLIC BOOLEAN display_partial_flag = TRUE; /* Display document during 
download */
 PUBLIC BOOLEAN debug_display_partial = FALSE; /* Show with MessageSecs delay */

reply via email to

[Prev in Thread] Current Thread [Next in Thread]