[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Lynx-dev] DJGPP patch for 2.8.6dev.18

From: Thomas Dickey
Subject: Re: [Lynx-dev] DJGPP patch for 2.8.6dev.18
Date: Mon, 24 Jul 2006 06:05:25 -0400 (EDT)

On Sun, 23 Jul 2006, Doug Kaufman wrote:

This is a minor patch for two items that affect portability to DJGPP.

The first is a change to aclocal.m4 from "test -f" to "test -x". This

but "test -x" isn't portable.

(I seem to recall that autoconf has some check for this feature in one of the versions, will look into that).

is important because if testing for "xgettext" and a file exists
called "xgettext.exe", "test -f" fails and "test -x" succeeds. Since
the line in aclocal.m4 is testing for an executable file, the change
shouldn't affect other platforms adversely. Without the patch, the
lynx configuration script doesn't find the utilities needed for NLS.
The change will be propagated to "configure" when autoconf is run.

The second is changing some very old code which excluded DJGPP from
using the envirnonment variable "LYNX_LOCALEDIR". This was probably
put in by me several years ago, although I don't remember exactly when
or why. I just did some testing and DJGPP NLS works fine with the code



--- lynx2.8.6dev.18/aclocal.m4.ori      2006-07-23 11:38:18.000000000 -0800
+++ lynx2.8.6dev.18/aclocal.m4  2006-07-23 12:03:12.000000000 -0800
@@ -264,7 +264,7 @@
  IFS="${IFS=      }"; ac_save_ifs="$IFS"; IFS="${IFS}${PATHSEP}"
  for ac_dir in ifelse([$5], , $PATH, [$5]); do
    test -z "$ac_dir" && ac_dir=.
-    if test -f $ac_dir/$ac_word; then
+    if test -x $ac_dir/$ac_word; then
      if [$3]; then
--- lynx2.8.6dev.18/src/LYMain.c.ori    2006-07-12 21:29:02.000000000 -0800
+++ lynx2.8.6dev.18/src/LYMain.c        2006-07-23 21:53:40.000000000 -0800
@@ -1094,11 +1094,9 @@
#endif /* LOCALE */
    /* Set the text message domain.  */
#if defined(HAVE_LIBINTL_H) || defined(HAVE_LIBGETTEXT_H)
-#ifndef __DJGPP__
    if ((cp = LYGetEnv("LYNX_LOCALEDIR")) == 0)
        cp = LOCALEDIR;
    bindtextdomain("lynx", cp);
-#endif /* !__DJGPP__ */
#endif /* HAVE_LIBINTL_H */

Doug Kaufman
Internet: address@hidden

Lynx-dev mailing list

Thomas E. Dickey

reply via email to

[Prev in Thread] Current Thread [Next in Thread]