[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Lynx-dev] [PATCH] DJGPP and MingW patch against 2.8.6rel.2

From: Doug Kaufman
Subject: [Lynx-dev] [PATCH] DJGPP and MingW patch against 2.8.6rel.2
Date: Sun, 15 Oct 2006 14:28:57 -0700 (PDT)

Here are some small suggested changes to get the 2.8.7dev series going.
Several different problems are rolled into one patch (attached), so I'll
try to go over the problems and possible solutions.

1. When the "endwin" function was added for PDCurses in LYCurses.c, the
code to clear the screen for DJGPP and MingW was (accidentally)
orphaned, so both were leaving the screen filled at exit. In trying to
put back the screen clearing code, I noticed that the MingW code had
never really worked. This attempts to fix the screen clearing problem
for the two platforms.

2. For MingW, configure was finding that "ln -s" worked, when run under
Cygwin with -mno-cygwin. I put in code to override that, since the links
made by Cygwin were not usable without Cygwin.

3. For MingW, when I switched to gettext 0.15 from 0.11.5, gettext was
getting undefined in LYMain.c. For reasons not clear to me, one of the
changes in the gettext versions was to now define gettext for MingW as
a macro. This didn't work with the code in LYMain.c. I chose to define
"_INTL_REDIRECT_INLINE", which prevents gettext from being defined as a
macro. It might be more general to instead wrap the undef of gettext in
LYMain.c in "#ifndef _INTL_REDIRECT_MACROS", but I wasn't sure exactly
what the undefining was supposed to do, so I left it MingW specific.

4. Per the recent discussion about being able to prevent downloading
and saving to disk on Win98, where users have full control, I put in a
define "LYNX_CRIPPLED" which, when defined at compile time, should make
downloading and saving to disk difficult, and with no way to override
this with command line arguments or settings in lynx.cfg.

5. Minor changes regarding SPAWNING_MSG, so that it works as intended.
Note that the SPAWNING_MSG text already has a newline at its end.

6. Lastly, I put in some code to automatically put the lynx icon into
the MingW binary. This uses windres, the Windows resource compiler that
is part of GNU binutils. Other Windows builds can probably use the
LYIcon.rc file and lynx.ico files, since LYIcon.rc should also be
compatible with the Microsoft Windows resource compiler. I use the lynx
icon "lynx.ico" dated March 15, 1997, which has been distributed with
Wayne Buttles' Windows binary packages of lynx. If this were to be
distributed in the src directory of lynx packages, it would make it
easier for those building various Windows binaries. I put the icon up at
my website at "";.

I hope that I haven't introduced too many problems with these changes.


Doug Kaufman
Internet: address@hidden

Attachment: rel2.pch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]