Re: [Lynx-dev] regression w.r.t. UI

[Thomas Dickey]

On Wed, Feb 22, 2012 at 10:37:00PM +0000, Thorsten Glaser wrote:
> Hi,
> 
> dev.11, lynx, startfile is my $HOME, I hit O, change something
> (e.g. send user-agent checkbox), confirm and get:
> 
> Alert!: Reloading document. Any form entries will be lost!
> 
> The document of course contains no forms.

The problem is this change:

* modify HTLoadDocument() to not retain a cached document if user is explicitly
  doing a refresh.  This fixes the case for a #fragment url, which was
  otherwise treated as the same as the address without the #fragment -TD

...which was the change to HTAccess in dev.10:

--- HTAccess.c  2012/02/04 00:15:53     1.76
+++ HTAccess.c  2012/02/23 00:11:48
@@ -687,11 +687,6 @@
     HTProtocol *p;
     int status = get_physical(addr, anchor);
 
-    if (reloading) {
-       FREE(anchor->charset);
-       FREE(anchor->UCStages);
-    }
-
     if (status == HT_FORBIDDEN) {
        /* prevent crash if telnet or similar was forbidden by rule. - kw */
        LYFixCursesOn("show alert:");
@@ -895,16 +890,15 @@
         * based on an If-Modified-Since check, etc.) but the code for doing
         * those other things isn't available yet.
         */
-       if (!reloading &&
-           (LYoverride_no_cache ||
+       if (LYoverride_no_cache ||
 #ifdef DONT_TRACK_INTERNAL_LINKS
-            !HText_hasNoCacheSet(text) ||
-            !HText_AreDifferent(anchor, full_address)
+           !HText_hasNoCacheSet(text) ||
+           !HText_AreDifferent(anchor, full_address)
 #else
-            ((LYinternal_flag || !HText_hasNoCacheSet(text)) &&
-             !isLYNXIMGMAP(full_address))
+           ((LYinternal_flag || !HText_hasNoCacheSet(text)) &&
+            !isLYNXIMGMAP(full_address))
 #endif /* TRACK_INTERNAL_LINKS */
-           )) {
+           ) {
            CTRACE((tfp, "HTAccess: Document already in memory.\n"));
            HText_select(text);
 
I guess that's going to be dev.12 (dev.13 presumably will have a
fix for the original problem...)

-- 
Thomas E. Dickey <address@hidden>
http://invisible-island.net
ftp://invisible-island.net

signature.asc
Description: Digital signature